diff options
| author |  tonvoon <ton.voon@opsview.com>
| 2010-06-30 07:56:05 +0000 |
|---|---|---|
| committer | tonvoon <ton.voon@opsview.com>
| 2010-06-30 07:56:05 +0000 |
| commit | 752dbc20b2bfbeb2b7d253b67fa6eda3adefb8c6 (patch) | |
| tree | 26e40ed9f3828acc4b1e4df36c144ca754bbe706 | |
| parent | 0aa751937455c4af4e49ccf6ba469c0b4ca8a4d0 (diff) | |
| download | monitoring-plugins-752dbc20b2bfbeb2b7d253b67fa6eda3adefb8c6.tar.gz | |
Tests for --rate-multiplier option
| -rw-r--r-- | plugins/check_snmp.c | 2 | ||||
| -rwxr-xr-x | plugins/tests/check_snmp.t | 13 |
2 files changed, 14 insertions, 1 deletions
diff --git a/plugins/check_snmp.c b/plugins/check_snmp.c index b16428fe..f8cae9b6 100644 --- a/plugins/check_snmp.c +++ b/plugins/check_snmp.c @@ -798,7 +798,7 @@ process_arguments (int argc, char **argv) calculate_rate = 1; break; case L_RATE_MULTIPLIER: - if(!is_integer(optarg)||(rate_multiplier=atoi(optarg)<=0)) + if(!is_integer(optarg)||((rate_multiplier=atoi(optarg))<=0)) usage2(_("Rate multiplier must be a positive integer"),optarg); break; case L_INVERT_SEARCH: diff --git a/plugins/tests/check_snmp.t b/plugins/tests/check_snmp.t index a7a8d2cf..0fa1691e 100755 --- a/plugins/tests/check_snmp.t +++ b/plugins/tests/check_snmp.t @@ -141,6 +141,19 @@ is($res->return_code, 0, "OK as no thresholds" ); is($res->output, "SNMP RATE OK - inoctets 333 | inoctets-rate=333 ", "Check rate decreases due to longer interval"); + +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 --rate -l inoctets_per_minute --rate-multiplier=60" ); +is($res->return_code, 0, "OK for first call" ); +is($res->output, "No previous data to calculate rate - assume okay" ); + +# Need to sleep, otherwise duration=0 +sleep 1; + +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 --rate -l inoctets_per_minute --rate-multiplier=60" ); +is($res->return_code, 0, "OK as no thresholds" ); +is($res->output, "SNMP RATE OK - inoctets_per_minute 11.1 | inoctets_per_minute-rate=11.1 ", "Checking multiplier"); + + $res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.11 -s '\"stringtests\"'" ); is($res->return_code, 0, "OK as string matches" ); is($res->output, 'SNMP OK - "stringtests" | ', "Good string match" ); |