Fixed SNMPv3 behaviour of check_ifstatus. Added -P to define privprotocol (#2343438 - Robin Schroeder)

check_ifstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.

Additionally the -P argument was added to specify the privprotocol.

1 files changed, 63 insertions, 0 deletions

diff --git a/plugins-scripts/t/check_ifstatus.t b/plugins-scripts/t/check_ifstatus.t
new file mode 100644
index 00000000..c5169d90
--- /dev/null
+++ b/plugins-scripts/t/check_ifstatus.t
@@ -0,0 +1,63 @@
+#! /usr/bin/perl -w -I ..
+#
+# SNMP Test via check_ifoperstatus
+#
+#
+
+use strict;
+use Test::More;
+use NPTest;
+
+my $tests = 9;
+plan tests => $tests;
+my $res;
+
+my $plugin = "check_ifstatus";
+SKIP: {
+	skip "$plugin is not created", $tests if ( ! -x $plugin );
+
+	my $host_snmp = getTestParameter( "host_snmp",          "NP_HOST_SNMP",      "localhost",
+	                                   "A host providing an SNMP Service");
+
+	my $snmp_community = getTestParameter( "snmp_community",     "NP_SNMP_COMMUNITY", "public",
+                                           "The SNMP Community string for SNMP Testing (assumes snmp v1)" );
+
+	my $host_nonresponsive = getTestParameter( "host_nonresponsive", "NP_HOST_NONRESPONSIVE", "10.0.0.1",
+	                                           "The hostname of system not responsive to network requests" );
+
+	my $hostname_invalid   = getTestParameter( "hostname_invalid",   "NP_HOSTNAME_INVALID",   "nosuchhost",
+	                                           "An invalid (not known to DNS) hostname" );
+
+	$res = NPTest->testCmd( "./$plugin" );
+	is( $res->return_code, 3, "No arguments" );
+	like( $res->output, '/usage/', "Output contains usage" );
+	
+	$res = NPTest->testCmd( "./$plugin -H fakehost -v 3 --seclevel rubbish --secname foobar" );
+	is( $res->return_code, 3, "invalid seclevel" );
+	like( $res->output, "/Must define a valid security level/", "Output contains 'Must define a valid security level'" );
+
+	SKIP: {
+		skip "no snmp host defined", 2 if ( ! $host_snmp );
+
+		$res = NPTest->testCmd( "./$plugin -H $host_snmp -C $snmp_community ");
+		like($res->output, '/^.*host.*interfaces up/', "String contains host.*interfaces up");
+
+		$res = NPTest->testCmd( "./$plugin -H $host_snmp -C rubbish");
+		cmp_ok( $res->return_code, '==', 2, "Exit CRITICAL for community 'rubbish'" ); 
+
+	}
+
+	SKIP: {
+		skip "no non responsive host defined", 1 if ( ! $host_nonresponsive );
+		$res = NPTest->testCmd( "./$plugin -H $host_nonresponsive -C $snmp_community");
+		cmp_ok( $res->return_code, '==', 2, "Exit CRITICAL with non responsive host" ); 
+	}
+
+	SKIP: {
+		skip "no invalid host defined", 2 if ( ! $hostname_invalid );
+		$res = NPTest->testCmd( "./$plugin -H $hostname_invalid -C $snmp_community");
+		cmp_ok( $res->return_code, '==', 3, "Exit UNKNOWN with invalid host" ); 
+		like($res->output, "/Unable to resolve.*$hostname_invalid/", "String matches unable to resolve.*$hostname_invalid");
+	}
+
+}