| Age | Commit message (Collapse) | Author |
|---|
|
Perl said: "Unrecognized escape \d passed through at ./t/check_dns.t
line 57."
|
|
sshutils prints the expiry time of certificates in US format
this patch uses the strftime %c, I don't know how portable that is
Thanks to Neil Prockter.
Closes #1188
Closes #1161
Closes #977
Closes #976
Closes #975
Closes #840
Closes #382
|
|
The perfdata output violates the current Nagios Plugin Development Guidelines
(http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN202 :
"space separated list of label/value pairs").
Thus the Addon PNP did not read the perdata correctly.
The patch replaces the commas with spaces in the perfdata output.
Many thanks to Patric Wust.
---
Closes #1169 and #721.
|
|
|
|
---
Closes #1160 and #973
|
|
|
|
|
|
closes #1236 and #1239
|
|
be easy to see which check caused the alert.
|
|
check_oracle in the 1.4.15 release doesn't correctly parse the output gotten
from at least Oracle 11 (with german locales). I guess it's probably more.
Also it completely needlessly uses sed where basic bash string parsing actually
does more than suffice (and does not run into possible problems with locales
like sed ;)).
--
Just turning attached patch of github issue #1015 into a push request.
(Closes #1015 and #1191)
|
|
|
|
|
|
|
|
|
|
check_procs: Add delay after forking in test
|
|
Forking raises a race condition, where the parent might run the
test before the child has had time to fork. If that happens,
an error similar to this is produced:
Failed test 'Output correct'
at ./t/check_procs.t line 32.
'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;'
doesn't match '/^PROCS OK: 1 process?/'
Sleeping a bit should avoid the problem. It might be enough to
sleep less than a second, but perl's built-in sleep function only
supports integer seconds.
In our build environment, the build failed 3 of 4 times before
this patch. After the patch it failed 0 of 7 times.
Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>
|
|
Tell users that check_snmp might now return CRITICAL in cases where it
used to return OK, and how to deal with that.
|
|
We're going to release version 2.0, not 1.6.
|
|
On at least FreeBSD, NetBSD, OpenBSD, DragonFly, and OS X, this is
hard-coded at 104 bytes.
Closes #1267.
|
|
As the FindBin module doesn't work with ePN, set the path to utils.pm
explicitly at build time. Keep using FindBin additionally, so that the
plugins can also be executed from the build directory.
Closes #1271.
|
|
As it is possible to use capabilities(7) on linux or solaris
privileges for example, it is not necessary in all cases to
have those binaries making use of setuid.
|
|
|
|
Update the THANKS.in file with the new Git commit authors.
|
|
|
|
|
|
check_ssh: check protocol
|
|
Include common.h before any system headers.
|
|
check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.
|
|
Serveral coverity fixes from nagios-plugins
|
|
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
Added two if elses to cover when only one threshold is set.
|
|
|
|
|
|
will help the admins when multiple checks are configured
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
|
|
|
|
Coverity 66502 - File descriptor fd in cmd_file_read is never closed, and thus file is left open after usage throughout runtime. - SR
|
|
Coverity 66479 - validate_arguments has no need to return anything, as it dies on error, yet was set to return an int. Set to void to resolve warning.
|
|
Coverity 66480 - Potential array index out of bounds, since result was not verified to be positive prior to using as an index for state[]. Simply reording the if statement should resolve the issue. - SR
|
|
Coverity 66488 - offer_packet->options has a max size of 312. It was being used in a loop verifying less than 311, but increasing by 2 per loop, causing a possible array index out of bounds. Changed to checking less than max length - 1. - SR
|
|
Coverity 66514 - Possible leakage and overflow with addr in redirect functionality. Not confirmed as null terminated, and externally gathered. Restrict string comparisons and duplications by size. - SR
|
|
Coverity 66524 - req.data is not neccessarily null terminated but still feed to printf statements. This both does that, and verifies the struct more so than before. - SR
|
|
Recv into buffer is not properly null terminated prior to strstr and possible other string functions expecting a null termination. Simply take bytes received and use as an index to append \0 after. We are creating buffer[] with size of MAX_INPUT_BUFFER and recv with MAX_INPUT_BUFFER-1 so this should never overflow.
|
|
Coverity 66531 - ereg.buffer can be printed without being initialized if do_include and do_exclude are null and critical is an invalid regex. While minor this may leak memory and cause undefined behavior.
|
|
This should fix some problems building on AIX.
|
|
tests: always build and test on travis
|
|
also make test is now working on travis-ci
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
|
|
|
|
|
|
|
Holger Weiss
Jan Wagner
abrist
Sam Kottler
Mikael Falkvidd
Sven Nierlein
Sven Nierlein
Jean-Claude Computing
Davide Madrisan
Spenser Reinhardt
Eric J. Mislivec