aboutsummaryrefslogtreecommitdiff
path: root/plugins
AgeCommit message (Collapse)Author
2014-02-18check_procs test fails if there is no user with uid 501Gravatar Sven Nierlein
thats because check_procs verifys there is a user for a given uid filter. So even we use sample data for this test, we still need a real user. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-02-17check_ssh: Reverting a387120Gravatar Jan Wagner
This seems to result into more problems in the wild then before 'fixing' it Closes Debian #739254 Reopen Debian #734811
2014-02-07Merge pull request #1234 from skottler/plugin_makefile_whitespaceGravatar Thomas Guyot-Sionnest
Remove unnecessary whitespace in Makefile.am
2014-02-07Remove unnecessary whitespace in Makefile.amGravatar Sam Kottler
2014-01-31Add perfdata in check_proc output testsGravatar Thomas Guyot-Sionnest
2014-01-31Fix snmpd testsGravatar Thomas Guyot-Sionnest
2014-01-31Enable tests in tests/ subdirsGravatar Thomas Guyot-Sionnest
2014-01-31Handle negative values properly with check_snmpGravatar Stephane Lapie
check_snmp becomes capable of evaluating negative values properly, but it might be returning CRITICALs where it used to return OK and was ignored, if a negative value turns out to actually be a valid value. If negative values are valid, this can be worked around, by adding "~:" to the warning/critical threshold : 100 -> ~:100
2014-01-31Add tests for negative thresholds in check_snmpGravatar Thomas Guyot-Sionnest
Next commit will work on fixing these!
2014-01-30check_dig: Declare variable at the topGravatar Holger Weiss
C89 doesn't allow variable declarations to be intermingled with code.
2014-01-30check_dig: stick with integer devisionGravatar Jan Wagner
This change saves us from having to link check_dig against "libm"
2014-01-30check_dig: timeout_interval is a global variableGravatar Jan Wagner
which is already set to 10 seconds
2014-01-30check_dig: patch to make dig honor -t optionGravatar Jan Wagner
When a timeout value is specified with the -t option, dig will sometimes timeout before the timer is actually reached. The problem occurs because the check_dig plugin does not pass the specified timeout value to dig, leaving dig to timeout with it's default value which seems to be around 10-15seconds. To reproduce: time ./check_dig -H 127.0.0.2 -l www.google.com -t 30 It will not run for 30secs, which is the expected behaviour. The following will work, because the timeout is less than the default dig timeout, so the plugin cancels the dig command: time ./check_dig -H 127.0.0.2 -l www.google.com -t 2 This fix passes the timeout value to dig, and sets the number of retries which tends to vary from system to system by default. Closes #1168
2014-01-29Update check_swap usageGravatar Thomas Guyot-Sionnest
2014-01-29check_swap: add supports for a configurable state when there is no swapGravatar Thomas Guyot-Sionnest
Check_swap used to allow no swap when thresholds were only specified in percent. This is no longer the case and the state now must be specified explicitly. The default is to always return CRITICAL when the swap is absent regardless of thresholds.
2014-01-29Move negate' translate_state() to utils_base.h mp_translate_state()Gravatar Thomas Guyot-Sionnest
Also use strcasecmp imported from gnulib for simplicity
2014-01-29TypoGravatar Thomas Guyot-Sionnest
2014-01-29Fix check_swap returning OK on & thresholds and no swapGravatar Thomas Guyot-Sionnest
Return 0% free instead of 100% free when total swap is 0
2014-01-28check_disk: precise the help outputGravatar Jan Wagner
Clarifying in the help output that we need either a device or mount point listed by the mount(8) command. (Closes: #1118) (Closes: #1170)
2014-01-28Clarify check_mysql test promptsGravatar Thomas Guyot-Sionnest
Also default to "-u test -ptest" which are default MySQL accounts only missing the prescribed privileges. The database is no longer specified as it is not used. If wanted is should be its own parameter/tests.
2014-01-27Merge pull request #1200 from awiddersheim/add_file_options_mysql_queryGravatar Thomas Guyot-Sionnest
Add ability to read from options file to check_mysql_query.c
2014-01-27check_dig: fix wrong IPv6 arguments orderGravatar Thomas Guyot-Sionnest
2014-01-27Rename MP_STATE_DIRECTORY to MP_STATE_PATHGravatar Thomas Guyot-Sionnest
2014-01-25Rename ENV variable, keep backward compatibilityGravatar Thomas Guyot-Sionnest
Rename NAGIOS_PLUGIN_STATE_DIRECTORY to MP_STATE_DIRECTORY
2014-01-24check_ping: Fixing "time of day goes back"Gravatar Jan Wagner
by Geoff Oakham <goakham at oanda.com> Patch of check_ping that allows it to gracefully handle when ping outputs to stderr "Warning: time of day goes back (-XXXXus), taking countermeasures." Closes: #809 and #1195
2014-01-24Fixing bug in average calculation (Submitted by Lars)Gravatar Jan Wagner
The more important change: A fix for a bug which caused the check_ntp_time and check_ntp_time check to always take the first response from ntp and not the avarage since "j" is not increased anywhere. "i" should be used there instead. Partly Closes #956 and Closes #1166 Closes: #1089
2014-01-24Making AVG_NUM configurable by compiler define (Submitted by Lars)Gravatar Jan Wagner
A minor change which makes the AVG_NUM configurable by compiler define. Partly Closed #956 and Closes #1166
2014-01-23fix smart attribute comparisonGravatar Tilmann Bubeck
Each S.M.A.R.T. attribute is compared against a threshold. If it is LESSTHAN that threshold an error is reported. This patch fixes the problem, that attribute values EQUAL to the threshold are reported as error, which is wrong. Only LESSTHAN the threshold is an error. For more information see: http://www.hdsentinel.com/smart/index.php My SSD has some attributes which value and threshold are "0". Without the patch this is reported as errornous. ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE ... 172 Unknown_Attribute 0x0032 000 000 000 Old_age Always - 0 174 Unknown_Attribute 0x0030 000 000 000 Old_age Offline - 13 177 Wear_Leveling_Count 0x0000 000 000 000 Old_age Offline - 0 ... See also: * http://sourceforge.net/p/nagiosplug/patches/365/ * https://bugzilla.redhat.com/913085
2014-01-23Fix misleading option textGravatar Thomas Guyot-Sionnest
As soon as a device is specified without using -d, anything else on the command line is ignored.
2014-01-23Disable SMART test commands in check_ide_smartGravatar Thomas Guyot-Sionnest
check_ide_smart could disable offline auto tests but could not re-enable them. For this reason all SMART command modes have been disabled The disabled commands are -0/--auto-off, -1/--auto-on and -i/--immediate
2014-01-23Remove accidental tabs inserted in macroGravatar Thomas Guyot-Sionnest
2014-01-23Make check_ide_smart default to nagios outputGravatar Thomas Guyot-Sionnest
check_ide_smart was originally a smard control utility later converted to a monitoring plugin. the -n option (Nagios check) should therefore be the default. This patch deprecates the -n and -q switches, and make the other switches return nagios-compatible output (they are most likely used in eventhandlers, but returning nagios-compatible output makes it clear and easy to handle the return status)
2014-01-22plugins/utils.h: avoiding warnings on empty printf statementsGravatar Ricardo Maraschini
while compiling i keep receiving an warning statement as follow: warning: zero-length gnu_printf format string using an unorthodox method to remove them Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
2014-01-21Capitalize "Monitoring Plugins"Gravatar Holger Weiss
"Monitoring Plugins" is a name.
2014-01-21Merge branch 'maint'Gravatar Holger Weiss
* maint: check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peer fixed tests when there is no direct internet connection NEWS: Mention fix for check_http's -S option Fix for SSL Versioning when multiple options are used. Fix #1217 spec file fails to build due to duplicate files and unused files check_http: Don't let "-N" expect an argument README: Change GitHub URL README: Clarify license notice Update URLs and mailing list addresses Just using the posix conform extended regular expression grep check_oracle: --db +ASM bad string matching check_oracle doesn't correctly check for pmon +ASM instance from at least Oracle 11 as the pmon proces was renamed from ora_pmon_.* to asm_pmon_.*. -- Just turning attached patch of github issue #1207 into a push request. (Closes #1207) Update web site URLs Conflicts: FAQ NEWS README SUPPORT configure.in monitoring-plugins.spec.in pkg/solaris/pkginfo.in plugins-root/check_dhcp.c plugins-root/check_icmp.c plugins-scripts/check_ifoperstatus.pl plugins-scripts/check_mssql.pl plugins/check_apt.c plugins/check_by_ssh.c plugins/check_cluster.c plugins/check_dbi.c plugins/check_dig.c plugins/check_disk.c plugins/check_dns.c plugins/check_dummy.c plugins/check_fping.c plugins/check_game.c plugins/check_hpjd.c plugins/check_http.c plugins/check_ide_smart.c plugins/check_ldap.c plugins/check_load.c plugins/check_mrtg.c plugins/check_mrtgtraf.c plugins/check_mysql.c plugins/check_mysql_query.c plugins/check_nagios.c plugins/check_nt.c plugins/check_ntp.c plugins/check_ntp_peer.c plugins/check_ntp_time.c plugins/check_nwstat.c plugins/check_overcr.c plugins/check_pgsql.c plugins/check_ping.c plugins/check_procs.c plugins/check_radius.c plugins/check_real.c plugins/check_smtp.c plugins/check_snmp.c plugins/check_ssh.c plugins/check_swap.c plugins/check_tcp.c plugins/check_time.c plugins/check_ups.c plugins/check_users.c plugins/negate.c plugins/urlize.c plugins/utils.h po/Makevars po/de.po po/fr.po po/monitoring-plugins.pot
2014-01-21Merge branch 'rename'Gravatar Thomas Guyot-Sionnest
2014-01-21New default installation prefix: /usr/localGravatar Holger Weiss
Install into /usr/local instead of /usr/local/nagios by default, in order to comply with the Filesystem Hierarchy Standard (FHS) and presumably the expectations of most users.
2014-01-21plugins/*.c: Non-network timeout changesGravatar Spenser Reinhardt
Changes to non-network checks for clarity on timeout value. Adapted from pull request #1209 tracker from user awiddersheim. (Closes: #1209) Files: check_apt.c, check_disk.c, check_procs.c, negate.c
2014-01-21plugins/utils.h: Addition of plugin timeout msg.Gravatar Spenser Reinhardt
Addition of timeout message for non-network plugins(UT_PLUG_TIMEOUT), and alteration of UT_TIMEOUT to UT_CONN_TIMEOUT for networked checks. Alteration of pull request #1209 tracker by user awiddersheim.
2014-01-21plugins/*.c: Alterations for timeout messages.Gravatar Spenser Reinhardt
.c file changes for misleading timeout messages in help functions. Solution to pull request #1209 tracker by awiddersheim. Files: plugins/check_apt.c, plugins/check_by_ssh.c, plugins/check_dbi.c, plugins/check_dig.c, plugins/check_disk.c, plugins/check_dns.c, plugins/check_game.c, plugins/check_http.c, plugins/check_ldap.c, plugins/check_ntp.c, plugins/check_ntp_peer.c, plugins/check_ntp_time.c, plugins/check_nwstat.c, plugins/check_overcr.c, plugins/check_pgsql.c, plugins/check_ping.c, plugins/check_procs.c, plugins/check_radius.c, plugins/check_real.c, plugins/check_smtp.c, plugins/check_snmp.c, plugins/check_ssh.c, plugins/check_tcp.c, plugins/check_time.c, plugins/check_ups.c, plugins/negate.c
2014-01-21Revert renaming valueGravatar Jan Wagner
As suggested by sreinhardt in 045d38a6 over there in nagios-plugins
2014-01-21Add performance data to check_mysql_query.c (Closes: #1202)Gravatar awiddersheim
2014-01-20Capitalize "Monitoring" when it's the first wordGravatar Holger Weiss
2014-01-20Minor fixes to be amended into "rename" commitGravatar Holger Weiss
2014-01-19Project rename initial commit.Gravatar Monitoring Plugins Development Team
This is an initial take at renaming the project to Monitoring Plugins. It's not expected to be fully complete, and it is expected to break things (The perl module for instance). More testing will be required before this goes mainline.
2014-01-10check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peerGravatar Jan Wagner
This fix was grabbed from FreeBSD downstream and provided by Dmitry Sivachenko. Fixes Debian Bug #734811
2013-12-27fixed tests when there is no direct internet connectionGravatar Sven Nierlein
- check http had wrong number of skipped tests - check tcp did not use the 'no internet' flag at all
2013-12-20Fix for SSL Versioning when multiple options are used.Gravatar Joseph Gooch
If you specify -S1 -C 30... The -C option will reset the ssl_version to 0. This is not a good thing. Instead we set the default to 0 and retain the version when later args are passed.
2013-12-05check_http: Don't let "-N" expect an argumentGravatar Holger Weiss
Fix the problem that check_http's "-N" option expects an argument although it shouldn't. The corresponding long option ("--no-body") wasn't affected. This error was introduced in ee3c4014d511e105489b081390636cacd4c53e3f. Thanks to Kerry Hughes for reporting it on the devel@ list.
2013-11-20make testing check_proc not rely on bashGravatar Sven Nierlein
also grandparents make this test fail but is not a problem in real live. NPTest->testCmd uses "sh -c" already, so there is no need to do that twice.