From 9c886d049d1dec9be0ac147c57d2094d2d4773da Mon Sep 17 00:00:00 2001 From: Sven Nierlein Date: Tue, 26 Jun 2012 20:53:13 +0200 Subject: Fix performance data label containing spaces in check_snmp (Jochen Bern) Add --perf-oids option for check_snmp to retain optional 1.4.14 compatibility --- plugins/tests/check_snmp.t | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) (limited to 'plugins/tests') diff --git a/plugins/tests/check_snmp.t b/plugins/tests/check_snmp.t index 2645cc1b..7a5a8b3f 100755 --- a/plugins/tests/check_snmp.t +++ b/plugins/tests/check_snmp.t @@ -8,7 +8,7 @@ use Test::More; use NPTest; use FindBin qw($Bin); -my $tests = 41; +my $tests = 51; # Check that all dependent modules are available eval { require NetSNMP::OID; @@ -144,6 +144,27 @@ is($res->return_code, 0, "OK as no thresholds" ); is($res->output, "SNMP RATE OK - inoctets 333 | inoctets=333 ", "Check rate decreases due to longer interval"); +# label performance data check +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 -l test" ); +is($res->return_code, 0, "OK as no thresholds" ); +is($res->output, "SNMP OK - test 67996 | test=67996c ", "Check label"); + +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 -l \"test'test\"" ); +is($res->return_code, 0, "OK as no thresholds" ); +is($res->output, "SNMP OK - test'test 68662 | \"test'test\"=68662c ", "Check label"); + +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 -l 'test\"test'" ); +is($res->return_code, 0, "OK as no thresholds" ); +is($res->output, "SNMP OK - test\"test 69328 | 'test\"test'=69328c ", "Check label"); + +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 -l test -O" ); +is($res->return_code, 0, "OK as no thresholds" ); +is($res->output, "SNMP OK - test 69994 | iso.3.6.1.4.1.8072.3.2.67.10=69994c ", "Check label"); + +$res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10" ); +is($res->return_code, 0, "OK as no thresholds" ); +is($res->output, "SNMP OK - 70660 | iso.3.6.1.4.1.8072.3.2.67.10=70660c ", "Check label"); + $res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.10 --rate -l inoctets_per_minute --rate-multiplier=60" ); is($res->return_code, 0, "OK for first call" ); -- cgit v1.2.3