From db5ef7c1b7f907d6856a5c8e16262725ce2b8a9b Mon Sep 17 00:00:00 2001 From: Jonas Gunz Date: Wed, 21 Sep 2022 17:03:43 +0200 Subject: fix crash on empty hostnames if no hostname is set on an IP Address, a None object is returned. Added a check for that to just ignore those. --- octodns-custom-providers/source/phpipam.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/octodns-custom-providers/source/phpipam.py b/octodns-custom-providers/source/phpipam.py index 46fe8a3..529dbdf 100755 --- a/octodns-custom-providers/source/phpipam.py +++ b/octodns-custom-providers/source/phpipam.py @@ -45,6 +45,10 @@ class PhpipamSource(octodns.source.base.BaseSource): def _populate_reverse(self, zone, selected_addresses): for hostname in selected_addresses: + if type(hostname) is not str: + # If an IP has no hostname set + continue + data={ 'type':'PTR', 'ttl':self._default_ttl, @@ -70,7 +74,12 @@ class PhpipamSource(octodns.source.base.BaseSource): zone.add_record( new_record ) def _populate_forward(self, zone, selected_addresses): + print(selected_addresses) for _selected_address in selected_addresses: + if type(_selected_address) is not str: + # If an IP has no hostname set + continue + if not _selected_address.endswith(zone.name.strip('.')): continue -- cgit v1.2.3