diff options
| author |  RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
| 2021-11-25 00:56:27 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-11-25 00:56:27 +0100 |
| commit | c39de8869e5352a5503607258996b8461ff27c14 (patch) | |
| tree | 6738b91799d8fe2c7885c1835ddd4ed4e2c71380 | |
| parent | 0e311b77d93df4b97c5f8cff73fea74a442ed4bc (diff) | |
| parent | 09bfb1b482f428b1c11f68b5be7d134ba5e3b457 (diff) | |
| download | monitoring-plugins-c39de8869e5352a5503607258996b8461ff27c14.tar.gz | |
Merge pull request #1727 from phibos/fix_check_ups_1030
Fix possible overflow in check_ups.
Looks good to me too, thank you very much
| -rw-r--r-- | plugins/check_ups.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/plugins/check_ups.c b/plugins/check_ups.c index e9e56a51..0de37a20 100644 --- a/plugins/check_ups.c +++ b/plugins/check_ups.c @@ -402,7 +402,10 @@ get_ups_variable (const char *varname, char *buf, size_t buflen) /* create the command string to send to the UPS daemon */ /* Add LOGOUT to avoid read failure logs */ - sprintf (send_buffer, "GET VAR %s %s\nLOGOUT\n", ups_name, varname); + if (snprintf (send_buffer, sizeof(send_buffer), "GET VAR %s %s\nLOGOUT\n", ups_name, varname) >= sizeof(send_buffer)) { + printf("%s\n", _("UPS name to long for buffer")); + return ERROR; + } /* send the command to the daemon and get a response back */ if (process_tcp_request |