diff options
| author |  Thomas Guyot-Sionnest <dermoth@users.sourceforge.net>
| 2008-05-20 07:57:13 +0000 |
|---|---|---|
| committer | Thomas Guyot-Sionnest <dermoth@users.sourceforge.net>
| 2008-05-20 07:57:13 +0000 |
| commit | eaf61e51ac6a64e3d879248edd7b10f62e3c6aa3 (patch) | |
| tree | e2509d41b6f05911259bb731c27ef718878cfcc0 /plugins/check_radius.c | |
| parent | 7e3fc482ed934105c3f27e39175bf0cff3286db3 (diff) | |
| download | monitoring-plugins-eaf61e51ac6a64e3d879248edd7b10f62e3c6aa3.tar.gz | |
Clobber password in check_radius process list aguments
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1994 f882894a-f735-0410-b71e-b25c423dba1c
Diffstat (limited to 'plugins/check_radius.c')
| -rw-r--r-- | plugins/check_radius.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/plugins/check_radius.c b/plugins/check_radius.c index 7ce820a8..5021a57a 100644 --- a/plugins/check_radius.c +++ b/plugins/check_radius.c @@ -260,7 +260,13 @@ process_arguments (int argc, char **argv) username = optarg; break; case 'p': /* password */ - password = optarg; + password = strdup(optarg); + + /* Delete the password from process list */ + while (*optarg != '\0') { + *optarg = 'X'; + optarg++; + } break; case 'n': /* nas id */ nasid = optarg; @@ -343,9 +349,9 @@ print_help (void) printf ("%s\n", _("name and password. A configuration file may also be present. The format of")); printf ("%s\n", _("the configuration file is described in the radiusclient library sources.")); printf ("%s\n", _("The password option presents a substantial security issue because the")); - printf ("%s\n", _("password can be determined by careful watching of the command line in")); - printf ("%s\n", _("a process listing. This risk is exacerbated because nagios will")); - printf ("%s\n", _("run the plugin at regular predictable intervals. Please be sure that")); + printf ("%s\n", _("password can possibly be determined by careful watching of the command line")); + printf ("%s\n", _("in a process listing. This risk is exacerbated because nagios will")); + printf ("%s\n", _("run the plugin at regular predictable intervals. Please be sure that")); printf ("%s\n", _("the password used does not allow access to sensitive system resources.")); #ifdef NP_EXTRA_OPTS |