diff options
author | Sven Nierlein <sven@nierlein.de> | 2013-02-10 22:57:55 +0100 |
---|---|---|
committer | Sven Nierlein <sven@nierlein.de> | 2013-02-10 23:09:49 +0100 |
commit | 5fce5ceaeb316a1701c49a9c966d60b602101ed9 (patch) | |
tree | 5a370106e96fc075ecfe7a36795cc9badf393006 /plugins/check_tcp.c | |
parent | f4bbd88a9f91bfbfbe590b3252043392e7248988 (diff) | |
download | monitoring-plugins-5fce5ceaeb316a1701c49a9c966d60b602101ed9.tar.gz |
check_tcp: don't ignore trailing options
"./check_tcp -6 -p 80 host" leads to an error:
TCP CRITICAL - Invalid hostname, address or socket: 127.0.0.1
because 127.0.0.1 is the fallback host, the tailing hostname
was ignored.
Diffstat (limited to 'plugins/check_tcp.c')
-rw-r--r-- | plugins/check_tcp.c | 25 |
1 files changed, 15 insertions, 10 deletions
diff --git a/plugins/check_tcp.c b/plugins/check_tcp.c index af3ae241..ce966c38 100644 --- a/plugins/check_tcp.c +++ b/plugins/check_tcp.c @@ -1,30 +1,30 @@ /***************************************************************************** -* +* * Nagios check_tcp plugin -* +* * License: GPL * Copyright (c) 1999-2008 Nagios Plugins Development Team -* +* * Description: -* +* * This file contains the check_tcp plugin -* -* +* +* * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. -* +* * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. -* +* * You should have received a copy of the GNU General Public License * along with this program. If not, see <http://www.gnu.org/licenses/>. * * $Id$ -* +* *****************************************************************************/ /* progname "check_tcp" changes depending on symlink called */ @@ -61,6 +61,7 @@ static int PORT = 0; static int server_port = 0; static char *server_address = NULL; +static int host_specified = FALSE; static char *server_send = NULL; static char *server_quit = NULL; static char **server_expect; @@ -462,6 +463,7 @@ process_arguments (int argc, char **argv) #endif break; case 'H': /* hostname */ + host_specified = TRUE; server_address = optarg; break; case 'c': /* critical */ @@ -588,6 +590,10 @@ process_arguments (int argc, char **argv) } } + c = optind; + if(host_specified == FALSE && c < argc) + server_address = strdup (argv[c++]); + if (server_address == NULL) usage4 (_("You must provide a server address")); else if (server_address[0] != '/' && is_host (server_address) == FALSE) @@ -666,4 +672,3 @@ print_usage (void) printf ("[-t <timeout seconds>] [-r <refuse state>] [-M <mismatch state>] [-v] [-4|-6] [-j]\n"); printf ("[-D <warn days cert expire>[,<crit days cert expire>]] [-S <use SSL>] [-E]\n"); } - |