aboutsummaryrefslogtreecommitdiff
path: root/plugins
diff options
context:
space:
mode:
authorGravatar Holger Weiss <holger@zedat.fu-berlin.de> 2015-10-12 11:07:02 +0200
committerGravatar Holger Weiss <holger@zedat.fu-berlin.de> 2015-10-12 11:07:02 +0200
commit11c5796d0a3ac3cb9ccbf004f67ebf6eabcc95bc (patch)
tree8ab31fe9b2e88319fe66155abb1ada2bad9a9641 /plugins
parent813b3bd5a40a94ee46b2092357439756c960ae20 (diff)
downloadmonitoring-plugins-11c5796d0a3ac3cb9ccbf004f67ebf6eabcc95bc.tar.gz
Revert "Don't let check_disk hang on hanging file systems"
This reverts commit 6986aa1d0a352d8d02eed4896034631fffd25a27. That commit leads to issues on non-Linux systems, and it seems to not (always) work as expected on Linux, either. Conflicts: plugins/Makefile.am plugins/check_disk.c Closes #1377 and closes #1329.
Diffstat (limited to 'plugins')
-rw-r--r--plugins/Makefile.am2
-rw-r--r--plugins/check_disk.c43
2 files changed, 1 insertions, 44 deletions
diff --git a/plugins/Makefile.am b/plugins/Makefile.am
index 41906c53..0ddf9bd1 100644
--- a/plugins/Makefile.am
+++ b/plugins/Makefile.am
@@ -71,7 +71,7 @@ check_apt_LDADD = $(BASEOBJS)
check_cluster_LDADD = $(BASEOBJS)
check_dbi_LDADD = $(NETLIBS) $(DBILIBS)
check_dig_LDADD = $(NETLIBS)
-check_disk_LDADD = $(BASEOBJS) $(THREADLIBS)
+check_disk_LDADD = $(BASEOBJS)
check_dns_LDADD = $(NETLIBS)
check_dummy_LDADD = $(BASEOBJS)
check_fping_LDADD = $(NETLIBS)
diff --git a/plugins/check_disk.c b/plugins/check_disk.c
index 9693bad3..874a0ee0 100644
--- a/plugins/check_disk.c
+++ b/plugins/check_disk.c
@@ -51,9 +51,6 @@ const char *email = "devel@monitoring-plugins.org";
# include <limits.h>
#endif
#include "regex.h"
-#if HAVE_PTHREAD_H
-# include <pthread.h>
-#endif
#ifdef __CYGWIN__
# include <windows.h>
@@ -133,7 +130,6 @@ void print_help (void);
void print_usage (void);
double calculate_percent(uintmax_t, uintmax_t);
void stat_path (struct parameter_list *p);
-void *do_stat_path (void *p);
void get_stats (struct parameter_list *p, struct fs_usage *fsp);
void get_path_stats (struct parameter_list *p, struct fs_usage *fsp);
@@ -972,44 +968,6 @@ print_usage (void)
void
stat_path (struct parameter_list *p)
{
-#ifdef HAVE_PTHREAD_H
- pthread_t stat_thread;
- int statdone = 0;
- int timer = timeout_interval;
- struct timespec req, rem;
-
- req.tv_sec = 0;
- pthread_create(&stat_thread, NULL, do_stat_path, p);
- while (timer-- > 0) {
- req.tv_nsec = 10000000;
- nanosleep(&req, &rem);
- if (pthread_kill(stat_thread, 0)) {
- statdone = 1;
- break;
- } else {
- req.tv_nsec = 990000000;
- nanosleep(&req, &rem);
- }
- }
- if (statdone == 1) {
- pthread_join(stat_thread, NULL);
- } else {
- pthread_detach(stat_thread);
- if (verbose >= 3)
- printf("stat did not return within %ds on %s\n", timeout_interval, p->name);
- printf("DISK %s - ", _("CRITICAL"));
- die (STATE_CRITICAL, _("%s %s: %s\n"), p->name, _("hangs"), _("Timeout"));
- }
-#else
- do_stat_path(p);
-#endif
-}
-
-void *
-do_stat_path (void *in)
-{
- struct parameter_list *p = in;
-
/* Stat entry to check that dir exists and is accessible */
if (verbose >= 3)
printf("calling stat on %s\n", p->name);
@@ -1019,7 +977,6 @@ do_stat_path (void *in)
printf("DISK %s - ", _("CRITICAL"));
die (STATE_CRITICAL, _("%s %s: %s\n"), p->name, _("is not accessible"), strerror(errno));
}
- return NULL;
}