aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-07-04Re-added missing variable declarations to check_smtp.cGravatar Eric Stanley
A recent update removed the declarations for a couple variables in check_smtp.c that are still being used, which caused a failure in the compilation of check_smtp.c. This commit restores those variable declarations so the check_smtp.c will again compile.
2012-06-29check_smtp: Remove a comment regarding MAIL FROMGravatar Holger Weiss
Earlier versions of check_smtp generated an (invalid) "MAIL FROM" command without arguments by default. These days, a "MAIL FROM" command is only sent if the --from option is specified. This commit removes a comment which explains the old behaviour, and it updates a variable name accordingly.
2012-06-29check_smtp: Fix help and usage output regarding -RGravatar Holger Weiss
2012-06-29NEWS, THANKS: Mention Anders Kaseorg's changesGravatar Holger Weiss
2012-06-29check_smtp: Fix strcat overflowsGravatar Anders Kaseorg
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29Die when asprintf failsGravatar Anders Kaseorg
Fixes many instances of warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Strip angle brackets from -f argument, if providedGravatar Anders Kaseorg
Apparently some people used -f '<nagios@example.com>' to work around the bug I just fixed in the MAIL FROM: command generation. Although the resulting command wasn't RFC-compliant, it was working with some MTAs, so let's continue to support this syntax now that we generate RFC-compliant commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Change MAIL FROM: command to comply with the SMTP standardGravatar Anders Kaseorg
Every version of the SMTP standard (from RFC 821 to the current RFC 5321) requires the address following MAIL FROM: to follow the colon immediately (with no space) and to be surrounded by angle brackets. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-28Remove the package.def fileGravatar Holger Weiss
The package.def file is not included in release tarballs, and I'm not aware of anyone (still) using it.
2012-06-27Remove #990948 from the BUGS fileGravatar Holger Weiss
Issue #990948 has been fixed by commit 0892c4ac28c4c2e3b6275187f845813b4cd6d320.
2012-06-27Prepare for the 1.4.16 releaseGravatar Holger Weiss
2012-06-27check_tcp: Print performance data even with -DGravatar Holger Weiss
When using the 1.4.15 release of the Nagios Plugins, a command such as check_tcp -H pop.example.com -p 995 -D 14 usually produced two lines of output, e.g.: OK - Certificate will expire on 12/13/2014 23:59. TCP OK - 0.009 second response time on port 995|time=0.008849s;;;0.000000;10.000000 The second line was removed by 4d06603060fc1233861b164870f0d3a2e0d8d2eb. However, as the old two-line output is a valid (though in this case unintended) way to spit out performance data, removing the second line might break current setups. Therefore, we revert to the old behaviour, at least for the moment. The issue was reported by Jochen Bern on the "nagiosplug-devel" mailing list (Message-ID: <4FEAE812.8030309@LINworks.de>).
2012-06-27Update the BUGS fileGravatar Holger Weiss
Remove the bug reports that were closed, and add two new items.
2012-06-27check_snmp: use single quotes for perf data labelsGravatar Sven Nierlein
2012-06-26Fix performance data label containing spaces in check_snmp (Jochen Bern)Gravatar Sven Nierlein
Add --perf-oids option for check_snmp to retain optional 1.4.14 compatibility
2012-06-26Remove team members from the THANKS fileGravatar Holger Weiss
The (current and past) team members are listed in the AUTHORS file.
2012-06-26Add Sven Nierlein to the list of AUTHORSGravatar Holger Weiss
2012-06-25added test case for certificate checs with both warning and critical valuesGravatar William Leibzon
2012-06-25check_http: added test for warning thresholdsGravatar Sven Nierlein
fixed typo in sslutils
2012-06-25updated changelogGravatar Sven Nierlein
2012-06-25applied patch that adds both critical and warning thresholds to certificate ↵Gravatar William Leibzon
expiration checks of check_tcp, check_http, check_smtp
2012-06-25check_ping: Add missing newline to die() callsGravatar Holger Weiss
Our die() function expects the caller to append the trailing newline character.
2012-06-25NEWS: Improve the wording a bitGravatar Holger Weiss
2012-06-25Merge remote-tracking branch 'github/waja/master'Gravatar Holger Weiss
Conflicts: NEWS
2012-06-24check_ping: Ignore ping(1)'s exit statusGravatar Holger Weiss
Don't return a WARNING state if the number of lost packets is greater than zero but below the specified warning threshold. This happened because the check_ping plugin used the exit status of the ping(1) utility. (#3535140 - Tobias Brox)
2012-06-23check_disk_smb: Add performance dataGravatar Holger Weiss
(Debian #654259 - Charles-Henri Larose)
2012-06-22Fix check_by_ssh test for non-Bash login shellsGravatar Holger Weiss
In the C shell and in the Z shell, the "?" character must be quoted or backslash-escaped in order to use it verbatim. Therefore, a command such as check_by_ssh -H test.example.com -l joe echo huh? might fail, depending on joe's login shell on test.example.com. Just to make sure, this commit removes most punctuation characters from our test strings.
2012-06-14check_dhcp: Don't misinterpret the "siaddr" fieldGravatar Holger Weiss
RFC 2131 (2.) says: "DHCP clarifies the interpretation of the 'siaddr' field as the address of the server to use in the next step of the client's bootstrap process." So, we shouldn't interpret this field as the DHCP server's own address. (#3503921 - Jason Ellison)
2012-06-13check_dhcp: Fix handling of "pad" optionsGravatar Holger Weiss
Don't let "pad" options[*] terminate the parsing of DHCP options. This bug was triggered by using check_dhcp against Windows 2003 DHCP servers (see #3503921). [*] Cf. RFC 2132, 3.1.
2012-06-11Improve parsing of ping6(1) outputGravatar Holger Weiss
The ping6(1) implementation provided by Debian's iputils-ping package may produce output such as the following: | 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms There's a corresponding pattern in check_ping.c:458: | "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss" Without this fix, the pattern in check_ping.c:456 matched first (as sscanf(3) interprets "+3" as a match for "%d"): | "%*d packets transmitted, %*d received, %d%% loss, time" (#1894850 - Debian bug report #514588 - Matej Vela)
2012-06-11Fix whitespace and capitalization issuesGravatar Holger Weiss
Fix indentation and whitespace issues, and correct some capitalization errors in error messages. The behaviour is unchanged.
2012-06-11Don't use SSLv2 when compiling against GnuTLSGravatar Holger Weiss
GnuTLS doesn't support SSL version 2.
2012-06-07check_users: Whitespace fixes, etc.Gravatar Holger Weiss
2012-06-07Update NEWS and THANKS w.r.t. check_users changeGravatar Holger Weiss
2012-06-07check_users: improve performanceGravatar M. Remy
This patch use the utxent function family to collect the user data. It improve the check speed. Need a system conforming to POSIX.1-2001.
2012-06-06sslutils: Check if OpenSSL supports SSLv2.Gravatar Sebastian Harl
Recent versions/builds seem to disable that feature.
2012-05-29Mention the check_range function in NEWS, etc.Gravatar Holger Weiss
2012-05-29Added check_range shell function to utils.sh.inGravatar Alex Griffin
2012-05-29check_http: Fix -C/--certificate option handlingGravatar Holger Weiss
The support for specifying the desired SSL protocol version via an optional -S/--ssl argument broke the -C/--certificate option. This is fixed now.
2012-05-28check_http: Don't ignore SSL initialization errorsGravatar Holger Weiss
SSL initialization errors are now handled properly by check_http (#3095106 - Eric Schoeller).
2012-05-28Add support for specifying SSL protocol versionGravatar Holger Weiss
The check_http -S/--ssl option now takes an optional argument which specifies the desired SSL/TLS protocol version (#3285367 - Jason Lunn).
2012-05-07Disable stateless SSL session resumptionGravatar Holger Weiss
Some versions of OpenSSL fail to negotiate the SSL connection with at least some versions of Tomcat if stateless SSL session resumption support (see RFC4507) is enabled: | CRITICAL - Cannot make SSL connection | 140099330348712:error:140943F2:SSL routines:SSL3_READ_BYTES:sslv3 alert unexpected message:s3_pkt.c:1195:SSL alert number 10 The problem is reproducible with OpenSSL 1.0.0h, but not with OpenSSL 0.9.8o-4squeeze12 (as shipped with Debian 6.0.4). We work around it by disabling the RFC4507 functionality when using OpenSSL versions which support it. Thanks to Dag Bakke for reporting the issue and for giving me access to a server I could use to reproduce the problem.
2012-04-17Add nagios-plugins.spec file to .gitignoreGravatar Holger Weiss
The nagios-plugins.spec file is created from nagios-plugins.spec.in and should be ignored by Git.
2012-04-17Fix check_ping where output of ping6 when unreachable (Debian #662638)Gravatar Jan Wagner
2012-04-10Merge branch 'master' of ↵Gravatar Matthias Eble
ssh://nagiosplug.git.sourceforge.net/gitroot/nagiosplug/nagiosplug
2012-04-09Mention check_by_ssh -F option in NEWS fileGravatar Holger Weiss
2012-04-09check_by_ssh: added -F config file to specify alternative ssh configGravatar Sven Nierlein
2012-04-06Merge branch 'master' of ↵Gravatar Eric Stanley
ssh://nagiosplug.git.sourceforge.net/gitroot/nagiosplug/nagiosplug
2012-04-06Updated to support compiling and building RPM on AIX.Gravatar Eric Stanley
2012-02-24Clarify that check_http won't verify certificatesGravatar Holger Weiss
Add a note to the --help output which clarifies that check_http doesn't perform certificate verification (beyond what the "-C" option does). (Suggested by Michael Renner in Debian bug report #644627, forwarded by Jan Wagner.)