aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-01-26Fix tests with an empty NPTest.cache fileGravatar Thomas Guyot-Sionnest
The NPTest.cache cannot be loaded when empty, and this prevents getting the data and populating the file. This patch skips the file when empty as if it didn't exist.
2014-01-25Ignore MP_STATE_DIRECTORY in suid pluginsGravatar Thomas Guyot-Sionnest
If a plugin still has suid privileges at the time np_enable_state() is called, the MP_STATE_DIRECTORY environment will be ignored. There is no need for a NEWS entry as no suid plugins use np_enable_state yet.
2014-01-25Clean up parse_ini error messages, add missing newlinesGravatar Thomas Guyot-Sionnest
2014-01-25Rename ENV variable, keep backward compatibilityGravatar Thomas Guyot-Sionnest
Rename NAGIOS_PLUGIN_STATE_DIRECTORY to MP_STATE_DIRECTORY
2014-01-24check_file_age: support for --ignore-missingGravatar Jan Wagner
Patch to provide for a -i | --ignore-missing option. This allows files that don't exist to be monitored for without causing an error. The use case is: * one process periodically pushes files to an "input" queue for a second process * the second process, when running cleanly will "consume" (process and remove) these files So the conditions to meet are: 1. If the file doesn't exist, that's fine (OK) 2. If the file exists, but is less than X seconds, that's fine (OK) 3. If the file exists, but greater than X seconds, no good (CRITICAL) Since now check_file_age doesn't permit this behavior, as a non-existent file is considered CRITICAL. Test case was contributed by our lovely Holger. Closes #1181, Closes #989, Closes #862, Closes #1187, Closes #845 Closes Debian Bug #496307
2014-01-24check_ping: Fixing "time of day goes back"Gravatar Jan Wagner
by Geoff Oakham <goakham at oanda.com> Patch of check_ping that allows it to gracefully handle when ping outputs to stderr "Warning: time of day goes back (-XXXXus), taking countermeasures." Closes: #809 and #1195
2014-01-24Fixing bug in average calculation (Submitted by Lars)Gravatar Jan Wagner
The more important change: A fix for a bug which caused the check_ntp_time and check_ntp_time check to always take the first response from ntp and not the avarage since "j" is not increased anywhere. "i" should be used there instead. Partly Closes #956 and Closes #1166 Closes: #1089
2014-01-24Making AVG_NUM configurable by compiler define (Submitted by Lars)Gravatar Jan Wagner
A minor change which makes the AVG_NUM configurable by compiler define. Partly Closed #956 and Closes #1166
2014-01-24Use access() instead of stat() in parse_ini.cGravatar Thomas Guyot-Sionnest
2014-01-24Update commentsGravatar Thomas Guyot-Sionnest
1. libtab is now bundled, so suggest to enable it rather than install it 2. "parse-ini" feature has been called "extra-opts"
2014-01-23Remove obsolete check_ntp.plGravatar Thomas Guyot-Sionnest
2014-01-23fix smart attribute comparisonGravatar Tilmann Bubeck
Each S.M.A.R.T. attribute is compared against a threshold. If it is LESSTHAN that threshold an error is reported. This patch fixes the problem, that attribute values EQUAL to the threshold are reported as error, which is wrong. Only LESSTHAN the threshold is an error. For more information see: http://www.hdsentinel.com/smart/index.php My SSD has some attributes which value and threshold are "0". Without the patch this is reported as errornous. ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE ... 172 Unknown_Attribute 0x0032 000 000 000 Old_age Always - 0 174 Unknown_Attribute 0x0030 000 000 000 Old_age Offline - 13 177 Wear_Leveling_Count 0x0000 000 000 000 Old_age Offline - 0 ... See also: * http://sourceforge.net/p/nagiosplug/patches/365/ * https://bugzilla.redhat.com/913085
2014-01-23Enable extra-opts by defaultGravatar Thomas Guyot-Sionnest
2014-01-23Fix misleading option textGravatar Thomas Guyot-Sionnest
As soon as a device is specified without using -d, anything else on the command line is ignored.
2014-01-23Disable SMART test commands in check_ide_smartGravatar Thomas Guyot-Sionnest
check_ide_smart could disable offline auto tests but could not re-enable them. For this reason all SMART command modes have been disabled The disabled commands are -0/--auto-off, -1/--auto-on and -i/--immediate
2014-01-23Remove accidental tabs inserted in macroGravatar Thomas Guyot-Sionnest
2014-01-23Make check_ide_smart default to nagios outputGravatar Thomas Guyot-Sionnest
check_ide_smart was originally a smard control utility later converted to a monitoring plugin. the -n option (Nagios check) should therefore be the default. This patch deprecates the -n and -q switches, and make the other switches return nagios-compatible output (they are most likely used in eventhandlers, but returning nagios-compatible output makes it clear and easy to handle the return status)
2014-01-22plugins/utils.h: avoiding warnings on empty printf statementsGravatar Ricardo Maraschini
while compiling i keep receiving an warning statement as follow: warning: zero-length gnu_printf format string using an unorthodox method to remove them Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
2014-01-22fix outdated Free Software Foundation addressGravatar Lars Vogdt
2014-01-21README: Minor fixes regarding new project nameGravatar Holger Weiss
Talk about "monitoring systems", not just about "Nagios". Also, the default installation prefix has changed to /usr/local. (While at it, wrap lines consistently at 76 characters.)
2014-01-21Capitalize "Monitoring Plugins"Gravatar Holger Weiss
"Monitoring Plugins" is a name.
2014-01-21Merge branch 'maint'Gravatar Holger Weiss
* maint: check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peer fixed tests when there is no direct internet connection NEWS: Mention fix for check_http's -S option Fix for SSL Versioning when multiple options are used. Fix #1217 spec file fails to build due to duplicate files and unused files check_http: Don't let "-N" expect an argument README: Change GitHub URL README: Clarify license notice Update URLs and mailing list addresses Just using the posix conform extended regular expression grep check_oracle: --db +ASM bad string matching check_oracle doesn't correctly check for pmon +ASM instance from at least Oracle 11 as the pmon proces was renamed from ora_pmon_.* to asm_pmon_.*. -- Just turning attached patch of github issue #1207 into a push request. (Closes #1207) Update web site URLs Conflicts: FAQ NEWS README SUPPORT configure.in monitoring-plugins.spec.in pkg/solaris/pkginfo.in plugins-root/check_dhcp.c plugins-root/check_icmp.c plugins-scripts/check_ifoperstatus.pl plugins-scripts/check_mssql.pl plugins/check_apt.c plugins/check_by_ssh.c plugins/check_cluster.c plugins/check_dbi.c plugins/check_dig.c plugins/check_disk.c plugins/check_dns.c plugins/check_dummy.c plugins/check_fping.c plugins/check_game.c plugins/check_hpjd.c plugins/check_http.c plugins/check_ide_smart.c plugins/check_ldap.c plugins/check_load.c plugins/check_mrtg.c plugins/check_mrtgtraf.c plugins/check_mysql.c plugins/check_mysql_query.c plugins/check_nagios.c plugins/check_nt.c plugins/check_ntp.c plugins/check_ntp_peer.c plugins/check_ntp_time.c plugins/check_nwstat.c plugins/check_overcr.c plugins/check_pgsql.c plugins/check_ping.c plugins/check_procs.c plugins/check_radius.c plugins/check_real.c plugins/check_smtp.c plugins/check_snmp.c plugins/check_ssh.c plugins/check_swap.c plugins/check_tcp.c plugins/check_time.c plugins/check_ups.c plugins/check_users.c plugins/negate.c plugins/urlize.c plugins/utils.h po/Makevars po/de.po po/fr.po po/monitoring-plugins.pot
2014-01-21Merge branch 'rename'Gravatar Thomas Guyot-Sionnest
2014-01-21New default installation prefix: /usr/localGravatar Holger Weiss
Install into /usr/local instead of /usr/local/nagios by default, in order to comply with the Filesystem Hierarchy Standard (FHS) and presumably the expectations of most users.
2014-01-21plugins/*.c: Non-network timeout changesGravatar Spenser Reinhardt
Changes to non-network checks for clarity on timeout value. Adapted from pull request #1209 tracker from user awiddersheim. (Closes: #1209) Files: check_apt.c, check_disk.c, check_procs.c, negate.c
2014-01-21plugins/utils.h: Addition of plugin timeout msg.Gravatar Spenser Reinhardt
Addition of timeout message for non-network plugins(UT_PLUG_TIMEOUT), and alteration of UT_TIMEOUT to UT_CONN_TIMEOUT for networked checks. Alteration of pull request #1209 tracker by user awiddersheim.
2014-01-21plugins/*.c: Alterations for timeout messages.Gravatar Spenser Reinhardt
.c file changes for misleading timeout messages in help functions. Solution to pull request #1209 tracker by awiddersheim. Files: plugins/check_apt.c, plugins/check_by_ssh.c, plugins/check_dbi.c, plugins/check_dig.c, plugins/check_disk.c, plugins/check_dns.c, plugins/check_game.c, plugins/check_http.c, plugins/check_ldap.c, plugins/check_ntp.c, plugins/check_ntp_peer.c, plugins/check_ntp_time.c, plugins/check_nwstat.c, plugins/check_overcr.c, plugins/check_pgsql.c, plugins/check_ping.c, plugins/check_procs.c, plugins/check_radius.c, plugins/check_real.c, plugins/check_smtp.c, plugins/check_snmp.c, plugins/check_ssh.c, plugins/check_tcp.c, plugins/check_time.c, plugins/check_ups.c, plugins/negate.c
2014-01-21Revert renaming valueGravatar Jan Wagner
As suggested by sreinhardt in 045d38a6 over there in nagios-plugins
2014-01-21Add performance data to check_mysql_query.c (Closes: #1202)Gravatar awiddersheim
2014-01-20Fix NPTest.pm not asking for unconfigured variablesGravatar Thomas Guyot-Sionnest
It appeats STDERR isn't a tty anymore during tests, but since we type from tty to STDIN it should be bound to our tty (and works for me).
2014-01-20updated perldod with a renamed pkgGravatar Sven Nierlein
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-01-20Capitalize "Monitoring" when it's the first wordGravatar Holger Weiss
2014-01-20Minor fixes to be amended into "rename" commitGravatar Holger Weiss
2014-01-19Minor mailinglist corrections for frenchGravatar Thomas Guyot-Sionnest
2014-01-19Reprocess L10n filesGravatar Thomas Guyot-Sionnest
2014-01-19Project rename initial commit.Gravatar Monitoring Plugins Development Team
This is an initial take at renaming the project to Monitoring Plugins. It's not expected to be fully complete, and it is expected to break things (The perl module for instance). More testing will be required before this goes mainline.
2014-01-13utils.sh: Don't define $ECHOGravatar Holger Weiss
In utils.sh, $ECHO was set to printf(1) or echo(1), depending on whether printf(1) is available in /usr/bin. This resulted in various bugs, as printf(1) cannot be used in the same way as echo(1). Thanks to Trevor Hemsley for reporting one of those bugs: If $ECHO was set to printf(1), check_log stumbled when reporting a log line with a "%" character.
2014-01-10check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peerGravatar Jan Wagner
This fix was grabbed from FreeBSD downstream and provided by Dmitry Sivachenko. Fixes Debian Bug #734811
2014-01-10configure.in: Call AC_CONFIG_HEADERSGravatar Holger Weiss
AM_CONFIG_HEADER is deprecated.
2013-12-27fixed tests when there is no direct internet connectionGravatar Sven Nierlein
- check http had wrong number of skipped tests - check tcp did not use the 'no internet' flag at all
2013-12-20NEWS: Mention fix for check_http's -S optionGravatar Holger Weiss
Closes #1220.
2013-12-20Fix for SSL Versioning when multiple options are used.Gravatar Joseph Gooch
If you specify -S1 -C 30... The -C option will reset the ssl_version to 0. This is not a good thing. Instead we set the default to 0 and retain the version when later args are passed.
2013-12-17Fix #1217 spec file fails to build due to duplicate files and unused filesGravatar Damian Myerscough
2013-12-05check_http: Don't let "-N" expect an argumentGravatar Holger Weiss
Fix the problem that check_http's "-N" option expects an argument although it shouldn't. The corresponding long option ("--no-body") wasn't affected. This error was introduced in ee3c4014d511e105489b081390636cacd4c53e3f. Thanks to Kerry Hughes for reporting it on the devel@ list.
2013-11-20make testing check_proc not rely on bashGravatar Sven Nierlein
also grandparents make this test fail but is not a problem in real live. NPTest->testCmd uses "sh -c" already, so there is no need to do that twice.
2013-11-20NEWS: Add WARNING regarding the check_procs changeGravatar Holger Weiss
Closes #1205.
2013-11-19check_procs: ignore plugin parent processGravatar Anton Lofgren
This fixes an issue that appears when running check_procs over NRPE, where the default shell is configured to (for example) dash, as is the case on Debian. dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process to execute the argument string. Contrast this with bash, which does not do this, provided that the argument string simply can be exec()'d as-is. To demonstrate: $ bash -c pstree init─┬ .. ... ├─sshd─-─sshd───pstree versus $ dash -c pstree init─┬ .. ... ├─sshd─-─sshd───dash───pstree The consequence of this fork is that the following invocation: /opt/plugins/check_procs -a init will result in this output: PROCS OK: 2 processes with args 'init' | processes=2;;;0; because the check_procs, in addition to finding the actual init process, finds its parent shell as well. This example is a bit contrived, but I think it illustrates the point. This wouldn't really be a problem, and normally isn't, if it weren't for the fact that NRPE uses a call to popen() which does exactly the above (executes '/bin/sh -c ...'), causing inconsistent behaviour between distributions and much confusion for end users. The argument may be made that the dash process spawned by NRPE is just a process like any other, and should therefore be included in the process count just like any other. However, this is not very intuitive, because of the previously mentioned inconsistencies. The argument might also well be made that we're _never_ interested in the immediate ancestor of the plugin, and while it is unknown how many installations have already made the necessary modifications to their setups to make up for the fact that the plugin behaves the way it does, it is not deemed worthwhile to entertain such workarounds. Thus, this patch ignores the parent process. See also these bug reports: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913 http://sourceforge.net/p/nagiosplug/bugs/512/ https://github.com/nagios-plugins/nagios-plugins/issues/999 https://bugs.op5.com/view.php?id=4398
2013-11-05README: Change GitHub URLGravatar Holger Weiss
Link to our main project home page on GitHub instead of referencing only the "nagios-plugins.git" repository. (And put the URL on its own line.)
2013-11-05README: Clarify license noticeGravatar Holger Weiss
Note that we permit redistribution and modification under the terms of future GPL versions, and state the exclusion of warranty. This is in accordance with the license notices at the top of our source files.
2013-10-28Update URLs and mailing list addressesGravatar Holger Weiss
Now that we moved our infrastructure away from SourceForge, update the URLs and mailing list addresses accordingly.
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-24 23:36:11 +0000