aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-07-29This patch will add the IP and port, or socket name, to the error message andGravatar Davide Madrisan
thus simplify the problem debugging: no need to check for this information in the Nagios configuration. This function is only used by 'check_tcp.c'. Without the patch: $ ./plugins/check_tcp -H 127.0.0.1 -p 21 Connection refused $ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd Permission denied With the patch: $ ./plugins/check_tcp -H 127.0.0.1 -p 21 connect to address 127.0.0.1 and port 21: Connection refused $ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd connect to socket /var/spool/nagios/cmd/nagios.cmd: Permission denied Thanks to Davide Madrisan. --- Closes #1277
2014-07-28check_mysql: ignore authentication failureGravatar Jan Wagner
This patch allows checking if MySQL server is running without providing valid username and password. Similar to check_ssh plugin it returns MySQL server version string and protocol number. Example: check_mysql -n -H aaa.bbb.ccc.ddd MySQL OK - Version: 5.0.51a-24+lenny5 (protocol 10) This is useful for monitoring servers where one does not have administrator privileges or does not want to grant any privileges for the monitoring station. To enable this functionality new option --ignore-auth (-n) is added to check_mysql plugin. Thanks to Julius Kriukas Closes #1020 Closes #1178
2014-07-21travis-ci: Installing libhttp-daemon-ssl-perl to make ↵Gravatar Jan Wagner
plugins/tests/check_http.t possible to run
2014-07-21Use "C" locale when running test suiteGravatar Holger Weiss
Some of our tests check locale-dependent plugin output, so let's make sure "make test" is always using the "C" locale.
2014-07-21plugins/tests/check_http.t: Adjust date stringsGravatar Holger Weiss
Adjust the expected date strings to the now-localized output produced by plugins/sslutils.c. Closes #1275.
2014-07-21travis-ci: Using libfreeradius-client-dev as build-depGravatar Jan Wagner
2014-07-21plugins/t/check_dns.t: Fix Perl warningGravatar Holger Weiss
Perl said: "Unrecognized escape \d passed through at ./t/check_dns.t line 57."
2014-07-21sslutils: expire time in local timezone formatGravatar Jan Wagner
sshutils prints the expiry time of certificates in US format this patch uses the strftime %c, I don't know how portable that is Thanks to Neil Prockter. Closes #1188 Closes #1161 Closes #977 Closes #976 Closes #975 Closes #840 Closes #382
2014-07-20check_ifstatus: perfdata bugGravatar Jan Wagner
The perfdata output violates the current Nagios Plugin Development Guidelines (http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN202 : "space separated list of label/value pairs"). Thus the Addon PNP did not read the perdata correctly. The patch replaces the commas with spaces in the perfdata output. Many thanks to Patric Wust. --- Closes #1169 and #721.
2014-07-20travis-ci: Adding ports for check_hpjdGravatar Jan Wagner
2014-07-20added tests for check_hpjd port optionsGravatar abrist
--- Closes #1160 and #973
2014-07-20Added check_hpjd port option to news and clarified the port usage error.Gravatar abrist
2014-07-20check_hpjd - Added a switch for port specification. Defaults to 161.Gravatar abrist
2014-07-20check_ntp.t - fixed tests for new status outputGravatar abrist
closes #1236 and #1239
2014-07-20check_ntp_peer - Added specific state output for each metric. It now should ↵Gravatar abrist
be easy to see which check caused the alert.
2014-07-11NEWS: Fix typoGravatar Holger Weiss
2014-07-11Prepare for the 2.0 releaseGravatar Holger Weiss
2014-07-11NEWS: Wrap overly long lineGravatar Holger Weiss
2014-07-10Update THANKS.in file with latest authorGravatar Holger Weiss
2014-07-10Merge pull request #1272 from mfalkvidd/masterGravatar Sam Kottler
check_procs: Add delay after forking in test
2014-07-10check_procs: Add delay after forking in testGravatar Mikael Falkvidd
Forking raises a race condition, where the parent might run the test before the child has had time to fork. If that happens, an error similar to this is produced: Failed test 'Output correct' at ./t/check_procs.t line 32. 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;' doesn't match '/^PROCS OK: 1 process?/' Sleeping a bit should avoid the problem. It might be enough to sleep less than a second, but perl's built-in sleep function only supports integer seconds. In our build environment, the build failed 3 of 4 times before this patch. After the patch it failed 0 of 7 times. Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>
2014-07-07NEWS: Add a warning regarding check_snmpGravatar Holger Weiss
Tell users that check_snmp might now return CRITICAL in cases where it used to return OK, and how to deal with that.
2014-07-07NEWS: Update version numberGravatar Holger Weiss
We're going to release version 2.0, not 1.6.
2014-07-07plugins/netutils.h: Adjust UNIX_PATH_MAX for BSDGravatar Holger Weiss
On at least FreeBSD, NetBSD, OpenBSD, DragonFly, and OS X, this is hard-coded at 104 bytes. Closes #1267.
2014-07-06Don't rely on FindBin module to locate utils.pmGravatar Holger Weiss
As the FindBin module doesn't work with ePN, set the path to utils.pm explicitly at build time. Keep using FindBin additionally, so that the plugins can also be executed from the build directory. Closes #1271.
2014-07-06check_icmp/check_dhcp: disable check, if we are rootGravatar Jan Wagner
As it is possible to use capabilities(7) on linux or solaris privileges for example, it is not necessary in all cases to have those binaries making use of setuid.
2014-07-06NEWS: Add missing entriesGravatar Holger Weiss
2014-07-06THANKS.in: Add new authorsGravatar Holger Weiss
Update the THANKS.in file with the new Git commit authors.
2014-06-30Merge PR #1265 from waja/check_tcp_server_addrGravatar Jan Wagner
2014-06-30check_jabber.t - fixed tests for new status output including hostnameGravatar abrist
2014-06-30Merge pull request #1190 from waja/github780Gravatar Sven Nierlein
check_ssh: check protocol
2014-06-28Merge pull request #1262 from waja/fix_aixGravatar Sven Nierlein
Include common.h before any system headers.
2014-06-28Merge pull request #1264 from waja/check_nt_unitsGravatar Sven Nierlein
check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.
2014-06-28Merge pull request #1263 from waja/coverity_fixesGravatar Sven Nierlein
Serveral coverity fixes from nagios-plugins
2014-06-28tests: added check_dns performance data testGravatar Sven Nierlein
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-28check_dns.c Added a bit more logic to thresholdsGravatar abrist
Added two if elses to cover when only one threshold is set.
2014-06-28check_dns: add warning and critical thresholds to perfdataGravatar Jean-Claude Computing
2014-06-28Cleaned up status output of check_tcp changesGravatar abrist
2014-06-28check_tcp: also display the server addr when host_specified is set. This ↵Gravatar Davide Madrisan
will help the admins when multiple checks are configured Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-06-28check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.Gravatar abrist
2014-06-28lib/utils_cmd.c - Free file descriptorGravatar Spenser Reinhardt
Coverity 66502 - File descriptor fd in cmd_file_read is never closed, and thus file is left open after usage throughout runtime. - SR
2014-06-28plugins/negate.c - Function should not return.Gravatar Spenser Reinhardt
Coverity 66479 - validate_arguments has no need to return anything, as it dies on error, yet was set to return an int. Set to void to resolve warning.
2014-06-28plugins/negate.c - Reorder if statement, aiobGravatar Spenser Reinhardt
Coverity 66480 - Potential array index out of bounds, since result was not verified to be positive prior to using as an index for state[]. Simply reording the if statement should resolve the issue. - SR
2014-06-28plugins-root/check_dhcp.c - array out of boundsGravatar Spenser Reinhardt
Coverity 66488 - offer_packet->options has a max size of 312. It was being used in a loop verifying less than 311, but increasing by 2 per loop, causing a possible array index out of bounds. Changed to checking less than max length - 1. - SR
2014-06-28plugins/check_http.c - leakage fixGravatar Spenser Reinhardt
Coverity 66514 - Possible leakage and overflow with addr in redirect functionality. Not confirmed as null terminated, and externally gathered. Restrict string comparisons and duplications by size. - SR
2014-06-28plugins/check_ntp.c - Verify struct from responseGravatar Spenser Reinhardt
Coverity 66524 - req.data is not neccessarily null terminated but still feed to printf statements. This both does that, and verifies the struct more so than before. - SR
2014-06-28plugins/check_real.c - recv string null terminateGravatar Spenser Reinhardt
Recv into buffer is not properly null terminated prior to strstr and possible other string functions expecting a null termination. Simply take bytes received and use as an index to append \0 after. We are creating buffer[] with size of MAX_INPUT_BUFFER and recv with MAX_INPUT_BUFFER-1 so this should never overflow.
2014-06-28plugins/check_apt.c - Print uninitialized eregGravatar Spenser Reinhardt
Coverity 66531 - ereg.buffer can be printed without being initialized if do_include and do_exclude are null and critical is an invalid regex. While minor this may leak memory and cause undefined behavior.
2014-06-28Include common.h before any system headers.Gravatar Eric J. Mislivec
This should fix some problems building on AIX.
2014-06-24Merge pull request #1261 from sni/masterGravatar Sven Nierlein
tests: always build and test on travis
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-24 07:41:04 +0000