| Age | Commit message (Collapse) | Author |
|---|
|
This was reported by clang, and in order for it to understand attributes
properly, I had to modify the macro that checks for non-gcc compilers.
Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
|
|
Before this patch, there was a constant, MAX_OIDS, that determined the
amount of slots most (but not all - see labels) array data structures
would have. It was set to 8.
Some users would like to use more than that, but rather than bumping the
constant, let's use the same type of logic we already use for labels -
grow the space 8 slots at a time. This will allow us to potentially
support an infinite amount of oids - or at least as many as the
packetsize on the SNMP server allows, which is usually significantly
smaller than infinity, yet often larger than 8.
Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
|
|
MySQL Requirements and Comments fix
|
|
http://sourceforge.net/tracker/index.php?func=detail&aid=3269273&group_id=29880&atid=397597
|
|
|
|
Fixes for check_apt handling of -i/-e/-c regexps and SECURITY_RE, plus tests
|
|
nagios.com seems to have changed their ip address. Also added tests
about -4/-6 option.
|
|
Add command line options -4 and -6 (--use-ipv4 and
--use-ipv6) to check_dig.
Effectively this adds no new functionality, just a
shortcut for:
check_dig -A "-4"
check_dig -A "-6"
Needed for using check_dig with the check_v46 wrapper
(see e.g.
https://gitorious.org/nagios-monitoring-tools/nagios-monitoring-tools/blobs/master/check_v46)
which requires -4/-6 command line option support.
|
|
|
|
The memory allocation mixed up number of bytes with number of pointers,
meaning as soon as we'd reach (on 64 bit systems) the second argument,
we'd start writing it outside of our allocated memory.
Normally, this isn't too visible, but as soon as you (again, on my 64
bit system) reach argument number 8, you get a segfault. It is easily
reproducible with:
check_snmp -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' \
-o '' -l '' -o '' -l '' -o '' -l '' -o '' -l ''
This patch allocates the proper amount of memory, to fix the issue.
Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
|
|
Description did not specify that it condition is critical if "stuff"
is less than zero.
|
|
My original patch was based on the online version which was apparently out of date.
In the meantime someone changed the description of example7 instead of the example. I think this is better because
otherwise example 6 and 7 are basically the same.
|
|
The last example in the table contradicted the previous example. Surely
it's purpose was to showcase the @ behaviour to invert threshold, but the
@ sign was missing.
I also clarified the description to the second last example so it is in same
style as the others.
|
|
connect errors may happen if clients check agains dual
stacked ipv4/6 ntp servers.
|
|
|
|
|
|
|
|
|
|
This adds support for @<range> and makes stuff a bit simpler by removing code
duplications.
Note: Previously, the compatibility code for 'check_procs <warn> <max>'
accepted something like 'check_procs -w 10:-1 -c 10:-1 20 50' as well
(treating it as if '-w 10:20 -c 10:50' was specified). This is no longer the
case ... additional arguments are only used as warn/crit thresholds in case
-w/-c is not specified at all.
|
|
The initial file was created in the user's home and later tested in the
doc directory. Instead, just rsync if the file is missing.
Also add some temporary files to gitignore/make clean
|
|
|
|
- fix sfwebcron (tool updating sf developer guidelines)
- remove obsolete snapshot script
|
|
|
|
Dying without a hint of what went wrong is just plain annoying. With
this patch we at least get a hint.
While at it, we fix the string offset so the output we're interested
in doesn't keep the equal sign that snmpget prints.
Signed-off-by: Andreas Ericsson <ae@op5.se>
|
|
Since the state patch introduction, we've been freeing uninitialized
memory in lib/utils_base.c::np_cleanup(), which caused coredumps
with check_snmp when illegal threshold ranges (for example) were
passed, or when we called 'die' without having read any state.
This patch fixes it by replacing the malloc() calls in there (all of
them, since using malloc() is almost always an error) with calloc().
malloc() either doesn't initialize the memory at all, or taints it
with a special marker so it can tell us when we're free()'ing memory
that hasn't been initialized. calloc() explicitly initializes the
allocated memory to nul bytes, which is a zero-cost operation when
we get the memory from the kernel (which alread does that) and almost
always desirable everywhere else.
Signed-off-by: Andreas Ericsson <ae@op5.se>
|
|
Once upon a time, check_snmp used to accept inverse ranges in the
format of '2:1' to mean "alert if value is inside this range".
Since commit 7cb3ae09334796f3b54e4e6438e38c2cc679b360, ranges such
as those have instead triggered the error "Range format incorrect"
and resulted in an UNKNOWN warning state. This patch attempts to
fix the situation so that the old-style ranges continues to mean
exactly what the once did and people with lots of snmp checks can
avoid a bazillion false positives from their environments.
Signed-off-by: Andreas Ericsson <ae@op5.se>
|
|
|
|
|
|
Let OpenSSL load its configuration file. See the OPENSSL_config(3) man
page for details.
(Suggested by Max Kosmach in Debian bug report #689960, forwarded by Jan
Wagner.)
|
|
Add a hidden "--input-file" option to check_apt (modelled on
check_procs) so that it can take files with sample apt output as input.
Add tests for my SECURITY_RE fix (debian3) and for the include, exclude
and critical options.
|
|
For the default security upgrade detection regular expression, match
"Debian-Security" in package description when it's anywhere after the
first parenthesis (not just the second space-delimited word). For
example:
... (4.0.1-5.4 Debian:6.0.6/stable, Debian-Security:6.0/stable ...
|
|
"critical" regular expressions. Instead, check for lines beginning
with "Inst" using strncmp and apply the regular expressions only when
such lines are found.
Fixes Debian bug #522812, along the lines suggested by the bug
submitter, Justin T Pryzby.
|
|
Update plugins/check_disk.c
|
|
CRITCAL -> CRITICAL typo
|
|
Bugfix: Detect array recovery percentages < 10% in check_linux_raid.pl
|
|
completion percentage to detect the percentage when there is more than
one space between between "recovery =" and the percentage. (When
the percentage is less than 10%, /proc/mdstat shows it left-padded
with an extra space: "recovery = 7.6%".)
|
|
Mention that the -C option now accepts two comma-separated values.
|
|
|
|
threshold data
|
|
In tests/check_http.t, tabs are used for indentation.
While at it, apply another few cosmetic changes.
|
|
|
|
Fix the test case which is meant to make sure that
check_http -C <n>,<m> [...]
returns a CRITICAL state if <m> is large enough.
|
|
|
|
Fix the threshold specifications in the example for checking the number
of truechimers.
Reported by Marc Haber on the "nagios-users" mailing list (Message-ID:
<20120722142840.GA6931@torres.zugschlus.de>).
|
|
Mention that the check_ntp_peer plugin checks the stratum of the
synchronization peer, not the stratum of the monitored server itself.
Thanks to Marc Haber for bringing this up on the "nagios-users" mailing
list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
|
|
In check_http.c, tabs aren't used for indentation.
|
|
The "ssl_version" variable was undeclared when the plugins were compiled
--without-openssl and --without-gnutls.
Bug reported by Michael LaCorte on the "nagiosplug-help" mailing list
(Message-ID: <CCD30C91-A2A8-463A-82A9-F99B54F741D3@gmail.com>).
|
|
|
|
|
|
A recent update removed the declarations for a couple variables in
check_smtp.c that are still being used, which caused a failure
in the compilation of check_smtp.c. This commit restores those variable
declarations so the check_smtp.c will again compile.
|
Robin Sonefors
Sven Nierlein
Daniël van Eeden
Sven Nierlein
Ville Mattila
palli
Pall Sigurdsson
Holger Weiss
Sebastian Harl
Thomas Guyot-Sionnest
dermoth
Andreas Ericsson
Marc Huffnagle
Alex Bradley
Gianluca Varisco
William Leibzon
Eric Stanley