aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-11-25Merge pull request #1727 from phibos/fix_check_ups_1030Gravatar RincewindsHat
Fix possible overflow in check_ups. Looks good to me too, thank you very much
2021-11-24Merge pull request #1682 from phibos/codeqlGravatar RincewindsHat
Add CodeQL checks
2021-11-24Fix possible overflow in check_ups (Fixes: #1030)Gravatar PhiBo
2021-11-19Merge pull request #1723 from RincewindsHat/check_swap_smallfix_and_styleGravatar RincewindsHat
Small fix to threshold validation and style (indentation) fixes
2021-11-19Merge pull request #1724 from mullumaus/masterGravatar RincewindsHat
Allows check_ldap to read password from environment variable
2021-11-19Allows check_ldap to get password from env variableGravatar Linda Guo
It's not secure to provide LDAP password through command line option because other users on the same host can see the password in 'ps' command output. This change allows check_ldap to get password from environment variable.
2021-11-19Fix option description authpassword -> authpasswdGravatar Lorenz Kästle
2021-11-19Revert "Fixed option description authpassword -> authpasswd + whitespaces"Gravatar Lorenz Kästle
This reverts commit b27e639725f680411aaa78dd9aa59cfff84ad0c5.
2021-11-19Fixed option description authpassword -> authpasswd + whitespacesGravatar Lorenz Kästle
2021-11-19Small fix to threshold validation and style (indentation) fixesGravatar RincewindsHat
2021-11-18Merge pull request #1697 from RincewindsHat/dont_show_rta_if_uselessGravatar RincewindsHat
check_ping: Do not show RTA if no connection was possible
2021-11-17Merge pull request #1654 from wolfgangkarall/masterGravatar RincewindsHat
check_procs -- exchange needle and haystack in strstr() for proper st…
2021-11-17Merge pull request #1688 from bazzisoft/masterGravatar RincewindsHat
check_curl.c: bugfix: verify certificates option should not force SSL to be used
2021-11-17Add thresholds even if value is missingGravatar RincewindsHat
2021-11-17homogenize perfdata function and fix small bug with missing semicolonGravatar RincewindsHat
2021-11-17Show RTA as unknown if it can not be determinedGravatar RincewindsHat
2021-11-17Do not show RTA if no connection was possibleGravatar rincewind
2021-11-17check_snmp: fix performance thresholds when using multiple oidsGravatar Sven Nierlein
when using check_snmp with multiple oids it simply printed the unparsed content from -w/-c into the thresholds for each oid. So each oid contained the hole -w from all oids. ./check_snmp ... -o iso.3.6.1.2.1.25.1.3.0,iso.3.6.1.2.1.25.1.5.0 -w '1,2' -c '3,4' before: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1,2;3,4 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;1,2;3,4 after: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1;3 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;2;4 This also applies to fixed thresholds since check_snmp translates negative infinities from: '~:-1' to '@-1:~'
2021-11-15check_icmp: Fix pkt perfdata in check_host modeGravatar Aksel Sjögren
Add missing "warn" threshold field in "pkt" perfdata output. Perfdata should be interpreted as; 'label'=value[UOM];[warn];[crit];[min];[max] With one field missing, the hardcoded min value '0' ended up in the "crit" field, making applications interpreting the perfdata thining that critical threshold is always exceeded. Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2021-11-11Merge pull request #1715 from ghen2/lmtpGravatar RincewindsHat
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).
2021-11-01check_procs: add test for elapsed timeGravatar Sven Nierlein
2021-11-01remove unused test fileGravatar Sven Nierlein
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01check_procs: improve ps args autodetectionGravatar Sven Nierlein
one of the first ps commands in the configure.ac is `axwo 'stat comm vsz rss user uid pid ppid args'` which works on most modern linux systems (checked debian 10/11 and centos 7/8). But this test misses the etime argument. Therefore `check_procs --metric=ELAPSED` does not work. To fix this, we simply do the same test including etime before that one. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01check_procs: remove trailing whitespaceGravatar Sven Nierlein
2021-10-28check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).Gravatar Geert Hendrickx
2021-10-28Merge pull request #1714 from ↵Gravatar RincewindsHat
RincewindsHat/fix_perfdata_for_big_values_for_check_disk Fix perfdata for big values for check disk. First merge \o/
2021-10-27Replace tabs with spaces and do some formattingGravatar RincewindsHat
2021-10-27Remove whitespace at the end of linesGravatar RincewindsHat
2021-10-26Fix my own errors for real this time and add some comments, so I wont do ↵Gravatar RincewindsHat
them again
2021-10-26Re-add separation semicolons for perfdata, which I deletedGravatar RincewindsHat
2021-10-26Reform some arithmetical operations for more clarityGravatar RincewindsHat
2021-10-26hopefully fix warning high tide with percentageGravatar RincewindsHat
2021-10-26Fix some testsGravatar RincewindsHat
2021-10-26Remove useless lines and fix some formattingGravatar RincewindsHat
2021-10-26Switch to uint64_tGravatar RincewindsHat
2021-10-26Reformat a little bit for easier readingGravatar RincewindsHat
2021-10-26Recognice IEC binary units and format accordingly to base2 (always)Gravatar RincewindsHat
2021-10-25Update check_load.tGravatar Harald Jenny
adjust tests for new plugin output
2021-10-25Create check_load.cGravatar Harald Jenny
just a cosmetic fix so the load plugin display a LOAD prefix before check results
2021-10-25actions: map utmp from host to containerGravatar Sven Nierlein
this fixes the check_users not having any logged in user to check.
2021-10-20Add comment to make the purpose of the nickname fix more obviousGravatar Lorenz Kästle
2021-10-20Restrict the nickname length of the test user for check_ircdGravatar Lorenz Kästle
check_ircd was using the string `ircd` plus the PID as a nickname for connecting to a IRC network by default. This caused errors, when the PID was too high and the network restricted the length of the nickname to 9 characters. This patch "fixes" this by just cutting it of, if it gets too big.
2021-10-03Merge remote-tracking branch 'monitoring-plugins/pr/1707'Gravatar Holger Weiss
* monitoring-plugins/pr/1707: Revert to poor man's logic Change all to comments to old comment style Fix comparing logic Remove spaces from tests check_swap: Fix perfdata und thresholds for big values and simplify code Introduce new perfdata functions and stuff for using (u)int64_t
2021-10-02Revert to poor man's logicGravatar RincewindsHat
2021-10-02Change all to comments to old comment styleGravatar RincewindsHat
2021-09-26Fix comparing logicGravatar RincewindsHat
2021-09-26Remove spaces from testsGravatar RincewindsHat
2021-09-25check_swap: Fix perfdata und thresholds for big values and simplify codeGravatar rincewind
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705 where the performance data output of check_swap did not conform to the parser logic of a monitoring system (which decided to go for "correct" SI or IEC units. The PR was accompanied by a change to byte values in the performance data which broke the _perfdata_ helper function which could not handle values of this size. The fix for this, was to use _fperfdata_ which could, but would use float values. I didn't like that (since all values here are discreet) and this is my proposal for a fix for the problem. It introduces some helper functions which do now explicitely work with (u)int64_t, including a special version of the _perfdata_ helper. In the process of introducing this to check_swap, I stumbled over several sections of the check_swap code which I found problematic. Therefore I tried to simplify the code and make it more readable and less redundant. I am kinda sorry about this, but sincerely hope my changes can be helpful.
2021-09-25Introduce new perfdata functions and stuff for using (u)int64_tGravatar rincewind
2021-09-02Improvements suggested by tobiaswieseGravatar Jonny007-MKD
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-23 05:19:27 +0000