aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-02Change all to comments to old comment styleGravatar RincewindsHat
2021-09-26Fix comparing logicGravatar RincewindsHat
2021-09-26Remove spaces from testsGravatar RincewindsHat
2021-09-25check_swap: Fix perfdata und thresholds for big values and simplify codeGravatar rincewind
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705 where the performance data output of check_swap did not conform to the parser logic of a monitoring system (which decided to go for "correct" SI or IEC units. The PR was accompanied by a change to byte values in the performance data which broke the _perfdata_ helper function which could not handle values of this size. The fix for this, was to use _fperfdata_ which could, but would use float values. I didn't like that (since all values here are discreet) and this is my proposal for a fix for the problem. It introduces some helper functions which do now explicitely work with (u)int64_t, including a special version of the _perfdata_ helper. In the process of introducing this to check_swap, I stumbled over several sections of the check_swap code which I found problematic. Therefore I tried to simplify the code and make it more readable and less redundant. I am kinda sorry about this, but sincerely hope my changes can be helpful.
2021-09-25Introduce new perfdata functions and stuff for using (u)int64_tGravatar rincewind
2021-09-02Improvements suggested by tobiaswieseGravatar Jonny007-MKD
2021-09-02check_dns: Fix memory leakGravatar Jonny007-MKD
2021-09-02check_dns: add --expect-nxdomainGravatar Jonny007-MKD
2021-09-01Merge pull request #1704 from RincewindsHat/use_openbsd_netcat_for_debian_testsGravatar Sven Nierlein
Use netcat-openbsd for debian explicitely
2021-09-01Use netcat-openbsd for debian explicitelyGravatar rincewind
2021-08-24Merge pull request #1388 from waja/check_proc_consumption_1357Gravatar Sven Nierlein
check_disk: Fixing the stuff that is broken on btrfs
2021-08-10Merge pull request #1700 from monitoring-plugins/feature_check_curlGravatar Sven Nierlein
Feature check curl
2021-07-28Merge branch 'master' into feature_check_curlGravatar Andreas Baumann
2021-07-25check_curl: fixed a potential buffer overflow in retir/uri_stringGravatar Andreas Baumann
2021-07-25check_curl: fixed DNS caching for SSL hostnames (avoid CURLOPT_RESOLVE entry ↵Gravatar Andreas Baumann
errors)
2021-07-22Merge pull request #1699 from peternewman/patch-1Gravatar Sven Nierlein
Re-attach a comment to where it actually belongs
2021-07-22Re-attach a comment to where it actually belongsGravatar Peter Newman
2021-07-08Merge pull request #1690 from ↵Gravatar Sven Nierlein
xFuture603/change_state_from_infinite_redirect_loop check_http: changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop
2021-07-05Merge pull request #1691 from RincewindsHat/no-host-check-for-check_by_sshGravatar Sven Nierlein
Let ssh decide if a host is valid, enables usage of ssh .config file
2021-07-04check_curl: changed to STATE_CRITICAL for infinite loops (-ffollow)Gravatar Andreas Baumann
2021-06-25Let ssh decide if a host is valid, enables usage of ssh .config fileGravatar Lorenz Kästle
2021-06-24fix for missing X509_up_ref on old systems with only OpenSSL 1.0Gravatar Andreas Baumann
2021-06-24changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loopGravatar Daniel Uhlmann
2021-06-24added option --enable-automatic-decompressionGravatar Andreas Baumann
2021-05-27Merge pull request #1689 from monitoring-plugins/feature_check_curlGravatar Sven Nierlein
fixes check_curl: "CRITICAL - Cannot retrieve certificate subject."
2021-05-27check_curl:Gravatar Andreas Baumann
- added verbose output in verify_callback - pin refcounting for certs (avoid subject extraction error when checking certs in is_openssl_callback mode)
2021-05-21Merge pull request #1686 from monitoring-plugins/feature_github_actionsGravatar Sven Nierlein
Migrate to GitHub actions
2021-05-20tests: ignore sigpipes in https test daemonGravatar Sven Nierlein
check_http closes the connection after checking the certificate with -C. This leads to sigpipe errors when the ssl daemon wants to send a response and the daemon quits which makes the subsequent tests fail.
2021-05-20tests: increase startup sleepGravatar Sven Nierlein
github action might fail from to time otherwise
2021-05-20remove useless commentsGravatar Sven Nierlein
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-05-19Prune container and volumesGravatar Jacob Hansen
Rather than manully removing the tmpfs volume. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-19Refactor check_fpingGravatar Jacob Hansen
* Set correct amount of tests based on conditionals. * When running the test as non-root, we would previously check is the setuid bit is set. This doesn't seem to be needed, so just check if the binary is executable for the user running the test. * Use cmp_ok to check if tests succeeds rather than couting. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-19Disable IPv6 in testsGravatar Jacob Hansen
Docker doesn't seem to have a working IPv6 stack by default. For now disable IPv6 tests. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-18check_curl.t: Adjust test to use -f curlGravatar Jacob Hansen
It appears that `-f follow` doesn't work correctly in `check_curl` at the moment. Test adjusted to use `-f curl` instead. Issue for the above created: https://github.com/monitoring-plugins/monitoring-plugins/issues/1685 Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-18Use openssl generated certGravatar Jacob Hansen
The SSL certificate generate using make-ssl-cert seems to not work well with a our plugins. Causing a "CN could not be found" error to be shown. Using an OpenSSL generated certifiticate, seems to work better. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-04-30Fix check_dhcp testsGravatar Aksel Sjögren
* try to use "/usr/sbin/ip" before "ifconfig" since the latter is obsolete on Linux to figure out interface to listen for DHCP messages. But keeping ifconfig method just in case. Without this, tests fail on boxes without ifconfig AND the correct interface named ethX. * amend possible failure responses, as check_dhcp might get a DHCPOFFER, but from an unexpected address - which happens if the box running tests are on a network with a DHCP server.
2021-04-30Add test-debug for plugins-rootGravatar Aksel Sjögren
Fixes "No rule to make target 'test-debug'" when running "make test-debug" in root dir.
2021-04-30Fix conditional tests for check_http, check_curlGravatar Aksel Sjögren
Set correct number of tests in skip- blocks to avoid the error "Bad plan. You planned 50 tests but ran 55" when run with/without /usr/bin/faketime and NP_INTERNET_ACCESS=yes/no.
2021-04-30Attempt to fix check_usersGravatar Jacob Hansen
Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-04-30migrate travis ci to github actionsGravatar Sven Nierlein
2021-04-30fix fping testGravatar Sven Nierlein
in case of dns errors, fping returns an unknown and thats ok.
2021-04-13check_curl: Fix bug where headers beginning with HTTP_ cause the status line ↵Gravatar Barak Shohat
parsing to fail.
2021-04-09Merge pull request #1671 from monitoring-plugins/feature_check_curlGravatar Sven Nierlein
Feature check curl
2021-04-08check_curl: backported --show-body/-B to print body (from check_http)Gravatar Andreas Baumann
2021-04-08check_curl: make -C obvious (from check_http, part 2)Gravatar Andreas Baumann
2021-04-08check_curl: make -C obvious (from check_http)Gravatar Andreas Baumann
2021-04-08check_curl: Increase regexp limit (to 1024 as in check_http)Gravatar Andreas Baumann
2021-04-07Merge pull request #1669 from bazzisoft/verify-certGravatar Sven Nierlein
Add an option to check_curl to verify the peer certificate & host using the system CA's
2021-04-07Merge pull request #1554 from stblassitude/masterGravatar Sven Nierlein
Docs check_http: make -C obvious
2021-04-07Merge pull request #1566 from hydrapolic/masterGravatar Sven Nierlein
plugins: check_http: Increase regexp limit