aboutsummaryrefslogtreecommitdiff
path: root/plugins/check_pgsql.c
AgeCommit message (Collapse)Author
2022-11-04Removing is_pg_dbname alltogether,using postgres API. (Closes: #1660) (#1803)Gravatar waja
The problem is that check_pgsql validates the Database name and has different assumptions that postgres itself. I fail to see a reason to validate the database name here. Postgres'es API should do this - So i would suggest a fix like this by removing is_pg_dbname alltogether. Co-authored-by: Florian Lohoff <f@zz.de>
2022-01-25add --queryname parameter to check_pgsql (#1741)Gravatar datamuc
This is used in the long output instead of the actual query. So instead of OK - 'select stuff from various, tables where some_stuff is null and other_stuff is not null' returned 42 one can use --queryname=check_greatest_basket and it will print OK - check_greatest_basket returned 42 That's nicer for alerting purposes, at least in our use case.
2021-02-15Using snprintf which honors the buffers size and guarantees null ↵Gravatar Florian Lohoff
termination. (Closes: #1601) As strcpy may overflow the resulting buffer: flo@p5:~$ /tmp/f/usr/lib/nagios/plugins/check_pgsql -d "$(seq 1 10000)" *** buffer overflow detected ***: terminated Aborted I would propose to change the code rather like this, using snprintf which honors the buffers size and guarantees null termination.
2019-02-15check_by_ssh: fix child process leak on timeoutsGravatar Sven Nierlein
When check_by_ssh runs into a timeout it simply exits keeping all child processes running. Simply adopting the kill loop from runcmd_timeout_alarm_handler() fixes this. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-12-01Spelling fixes suggested by lintianGravatar Jan Wagner
2015-10-04use unknown exit code for help/version in pluginsGravatar Sven Nierlein
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-03-13check_pgsql: Add missing newline to --help outputGravatar Holger Weiss
2014-01-21Merge branch 'rename'Gravatar Thomas Guyot-Sionnest
2014-01-21plugins/*.c: Alterations for timeout messages.Gravatar Spenser Reinhardt
.c file changes for misleading timeout messages in help functions. Solution to pull request #1209 tracker by awiddersheim. Files: plugins/check_apt.c, plugins/check_by_ssh.c, plugins/check_dbi.c, plugins/check_dig.c, plugins/check_disk.c, plugins/check_dns.c, plugins/check_game.c, plugins/check_http.c, plugins/check_ldap.c, plugins/check_ntp.c, plugins/check_ntp_peer.c, plugins/check_ntp_time.c, plugins/check_nwstat.c, plugins/check_overcr.c, plugins/check_pgsql.c, plugins/check_ping.c, plugins/check_procs.c, plugins/check_radius.c, plugins/check_real.c, plugins/check_smtp.c, plugins/check_snmp.c, plugins/check_ssh.c, plugins/check_tcp.c, plugins/check_time.c, plugins/check_ups.c, plugins/negate.c
2014-01-20Capitalize "Monitoring" when it's the first wordGravatar Holger Weiss
2014-01-19Project rename initial commit.Gravatar Monitoring Plugins Development Team
This is an initial take at renaming the project to Monitoring Plugins. It's not expected to be fully complete, and it is expected to break things (The perl module for instance). More testing will be required before this goes mainline.
2013-09-19check_pgsql: Don't exit UNKNOWN instead of OKGravatar Holger Weiss
Since commit 912df3ef9b188c82893dace1e9b56c42a558fdba, check_pgsql exited UNKNOWN instead of OK if the new --query option was *not* specified. This bug is fixed now.
2013-08-17check_pgsql: Add missing printf(3) argumentGravatar Holger Weiss
2013-08-17check_pgsql: Remove -4/-6 flags from help outputGravatar Holger Weiss
The -4/-6 options are currently not supported.
2013-08-17Merge remote-tracking branch 'github/tokkee/sh/check_pgsql'Gravatar Holger Weiss
* github/tokkee/sh/check_pgsql: check_pgsql: Determine connection time in µs-resolution. check_pgsql: Leave 'min' value in query perfdata empty. check_pgsql: Updated copyright. check_pgsql: Added support for the -o command line option. check_pgsql: Removed -4/-6 flags from help output. check_pgsql: Allow UNIX socket directories as hostname as well. check_pgsql: Use PQconnectdb() rather than PQsetdbLogin(). check_pgsql: Fixed query perfdata output for empty warn/crit ranges. check_pgsql: Added support for executing queries. Conflicts: plugins/check_pgsql.c
2012-11-28unified ipv4/6 usage and help textGravatar Sven Nierlein
2012-07-05check_pgsql: Determine connection time in µs-resolution.Gravatar Sebastian Harl
… thus, treat "elapsed time" and the thresholds as floating point values.
2012-07-05check_pgsql: Leave 'min' value in query perfdata empty.Gravatar Sebastian Harl
There is no reasonable default value for that.
2012-07-05check_pgsql: Updated copyright.Gravatar Sebastian Harl
2012-07-05check_pgsql: Added support for the -o command line option.Gravatar Sebastian Harl
This option may be used to specify further connection parameters to be passed to PQconnectdb(). For example, this may be used to specify a service name in pg_service.conf to be used for additional connection parameters: -o 'service=<name>' or to specify the SSL mode: -o 'sslmode=require'. See the chapter "libpq - C Library" in the PostgreSQL manual for details.
2012-07-05check_pgsql: Removed -4/-6 flags from help output.Gravatar Sebastian Harl
These options are not currently supported.
2012-07-05check_pgsql: Allow UNIX socket directories as hostname as well.Gravatar Sebastian Harl
PostgreSQL accepts the directory name of its UNIX socket as hostname as well, e.g. /var/run/postgresql/.
2012-07-05check_pgsql: Use PQconnectdb() rather than PQsetdbLogin().Gravatar Sebastian Harl
This is more flexible and the recommended way to connect to a PostgreSQL database. Also, the verbose output now includes detailed information about the connection.
2012-07-05check_pgsql: Fixed query perfdata output for empty warn/crit ranges.Gravatar Sebastian Harl
Previously, "(null)" was printed (when using GNU's libc). This has been changed to print the empty string instead.
2012-07-05check_pgsql: Added support for executing queries.Gravatar Sebastian Harl
The query result (the double value of the first column in the first row, to be precise) will be checked against threshold ranges specified using the -C and -W options. Note that this also allows to query PostgreSQL internal values using the information available from the database daemon's "statistics collector" -- see the chapter "Monitoring Database Activity" in the PostgreSQL manual for details.
2012-06-29Die when asprintf failsGravatar Anders Kaseorg
Fixes many instances of warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2010-04-22Add newline after "Usage:" in --helpGravatar Thomas Guyot-Sionnest
2010-04-21Standardize the extra-opts notesGravatar Thomas Guyot-Sionnest
2010-04-14Fix translations when extra-opts aren't enabledGravatar Thomas Guyot-Sionnest
Bug #2832884 reported problem with translations outputting pot file headers. This is caused by "" matching the header of the translation files. This patch moves gettext macros inside utils macros and update some french translations.
2009-06-01Whitespace indent fixes for check_pgsqlGravatar Matthias Eble
2009-06-01Added verbose output to check_pgsql (#2799281 - Jun Kuriyama)Gravatar Matthias Eble
check_pgsql displayed the -v flag in help output, but didn't accept the verbosity argument. Added -v and basic verbose output.
2008-11-23Removing CVS/SVN tags and replacing with git-based versioningGravatar Thomas Guyot-Sionnest
For contrib/, full tags have been imported from subversion git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-19Bulk EOL cleanupGravatar Thomas Guyot-Sionnest
$ git diff --ignore-space-change|diffstat 0 files changed git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2087 f882894a-f735-0410-b71e-b25c423dba1c
2008-05-07Added support for --extra-opts in all C plugins (disabled by default, see ↵Gravatar Thomas Guyot-Sionnest
configure --help) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1991 f882894a-f735-0410-b71e-b25c423dba1c
2008-04-27--help output cleanup (plus removal of spaces on blank lines)Gravatar Thomas Guyot-Sionnest
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1984 f882894a-f735-0410-b71e-b25c423dba1c
2008-02-13check_pgsql now builds with postgres lib v8.3 (Jan Wagner #1878972)Gravatar Matthias Eble
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1934 f882894a-f735-0410-b71e-b25c423dba1c
2008-01-31Bump plugin/ to GPLv3 (check_overcr to check_users)Gravatar Thomas Guyot-Sionnest
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1917 f882894a-f735-0410-b71e-b25c423dba1c
2007-01-28Don't try to print `optarg' (which will be a NULL pointer) if an unknownGravatar Holger Weiss
command line option was used, as this leads to a segfault on some systems. The unknown option will be printed by getopt(3) anyway. So, simply call print_usage() and exit UNKNOWN via the new usage5() instead. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1590 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19first pass at cleaning localization for new releaseGravatar Benoit Mortier
first pass at making all the headre be the same licence, plugin, etc... git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1499 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-17cleaning up help and usageGravatar Benoit Mortier
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1433 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-06modify the is_pg_dbname() function to allow databases with '-' in their name.Gravatar M. Sean Finney
reference: sf tracker #1500752 git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1414 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-25various fixes for localizationGravatar Benoit Mortier
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1061 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-10Fixing broken compileGravatar Matthew Kent
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1021 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03reverting my changes from !=TRUE to == ERROR, that's not good ;-( sorryGravatar Benoit Mortier
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@998 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03print_help and print_usage() cleanupGravatar Benoit Mortier
other misc cleanups git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@996 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03remove UT_HLP_VRS from print_usageGravatar Benoit Mortier
this was not a good idea ;-) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@994 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03fixes for internationalizationGravatar Benoit Mortier
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@990 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03Localization fixesGravatar Benoit Mortier
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@988 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03correcting copyright and remaning int result = STATE_UNKNOWN;Gravatar Benoit Mortier
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@987 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03bump copyright yearGravatar Benoit Mortier
initialize result to STATE_UNKNOW in place of STATE_OK git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@982 f882894a-f735-0410-b71e-b25c423dba1c
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-22 03:01:02 +0000