diff options
| author |  Jan Wagner <waja@cyconet.org>
| 2013-10-01 14:59:35 +0200 |
|---|---|---|
| committer | Jan Wagner <waja@cyconet.org>
| 2014-07-20 22:30:21 +0200 |
| commit | d8b81e9ef3947a36e2647f4e54a63e3b259b103b (patch) | |
| tree | 8e78ec643476324f0ab7f9baf692653ad1afe7b9 | |
| parent | 50cad9ae5d958f045fcea927b41b52d24ff59b91 (diff) | |
| download | monitoring-plugins-d8b81e9ef3947a36e2647f4e54a63e3b259b103b.tar.gz | |
check_oracle: --tns bad string matching
check_oracle in the 1.4.15 release doesn't correctly parse the output gotten
from at least Oracle 11 (with german locales). I guess it's probably more.
Also it completely needlessly uses sed where basic bash string parsing actually
does more than suffice (and does not run into possible problems with locales
like sed ;)).
--
Just turning attached patch of github issue #1015 into a push request.
(Closes #1015 and #1191)
| -rw-r--r-- | THANKS.in | 1 | ||||
| -rwxr-xr-x | plugins-scripts/check_oracle.sh | 2 |
2 files changed, 2 insertions, 1 deletions
@@ -323,3 +323,4 @@ Eric J. Mislivec Jean-Claude Computing Andy Brist Mikael Falkvidd +Frederic Krueger diff --git a/plugins-scripts/check_oracle.sh b/plugins-scripts/check_oracle.sh index ceac95dc..1873a3c2 100755 --- a/plugins-scripts/check_oracle.sh +++ b/plugins-scripts/check_oracle.sh @@ -137,7 +137,7 @@ case "$cmd" in tnschk=` tnsping $2` tnschk2=` echo $tnschk | grep -c OK` if [ ${tnschk2} -eq 1 ] ; then - tnschk3=` echo $tnschk | sed -e 's/.*(//' -e 's/).*//'` + tnschk3=${tnschk##*(}; tnschk3=${tnschk3%)*} echo "OK - reply time ${tnschk3} from $2" exit $STATE_OK else |