aboutsummaryrefslogtreecommitdiff
path: root/plugins/t/check_fping.t
diff options
context:
space:
mode:
authorGravatar Sven Nierlein <Sven.Nierlein@consol.de> 2018-12-04 15:20:18 +0100
committerGravatar Sven Nierlein <Sven.Nierlein@consol.de> 2018-12-04 15:20:19 +0100
commitd7dcca22ae2f7bdf0ee2282e00c1999de0b58e26 (patch)
tree56c6268f2a2481ff7b866ccd09c2005d7ec24a67 /plugins/t/check_fping.t
parentb69eb5afed40f14ba648c3358e2b46aeb75b0c5d (diff)
downloadmonitoring-plugins-d7dcca22ae2f7bdf0ee2282e00c1999de0b58e26.tar.gz
tests: rework test parameters
there were 2 variants of calling getTestParameter: - parameter, description, default value - parameter, env value, default value, description, scope While scope was never actually used and having 2 names for the same value led to having 2 different entries in the cache file for the same configuration. This commit removes the variants and simplifies tests parameters by only using the first 3 parameter variant.
Diffstat (limited to 'plugins/t/check_fping.t')
-rw-r--r--plugins/t/check_fping.t12
1 files changed, 3 insertions, 9 deletions
diff --git a/plugins/t/check_fping.t b/plugins/t/check_fping.t
index 08692e46..342b0a7e 100644
--- a/plugins/t/check_fping.t
+++ b/plugins/t/check_fping.t
@@ -15,15 +15,9 @@ BEGIN {$tests = 4; plan tests => $tests}
my $successOutput = '/^FPING OK - /';
my $failureOutput = '/^FPING CRITICAL - /';
-my $host_responsive = getTestParameter( "host_responsive", "NP_HOST_RESPONSIVE", "localhost",
- "The hostname of system responsive to network requests" );
-
-my $host_nonresponsive = getTestParameter( "host_nonresponsive", "NP_HOST_NONRESPONSIVE", "10.0.0.1",
- "The hostname of system not responsive to network requests" );
-
-my $hostname_invalid = getTestParameter( "hostname_invalid", "NP_HOSTNAME_INVALID", "nosuchhost",
- "An invalid (not known to DNS) hostname" );
-
+my $host_responsive = getTestParameter("NP_HOST_RESPONSIVE", "The hostname of system responsive to network requests", "localhost");
+my $host_nonresponsive = getTestParameter("NP_HOST_NONRESPONSIVE", "The hostname of system not responsive to network requests", "10.0.0.1");
+my $hostname_invalid = getTestParameter("NP_HOSTNAME_INVALID", "An invalid (not known to DNS) hostname", "nosuchhost");
my $t;