diff options
| author |  Sven Nierlein <Sven.Nierlein@consol.de>
| 2018-12-04 15:20:18 +0100 |
|---|---|---|
| committer | Sven Nierlein <Sven.Nierlein@consol.de>
| 2018-12-04 15:20:19 +0100 |
| commit | d7dcca22ae2f7bdf0ee2282e00c1999de0b58e26 (patch) | |
| tree | 56c6268f2a2481ff7b866ccd09c2005d7ec24a67 /plugins/t/check_jabber.t | |
| parent | b69eb5afed40f14ba648c3358e2b46aeb75b0c5d (diff) | |
| download | monitoring-plugins-d7dcca22ae2f7bdf0ee2282e00c1999de0b58e26.tar.gz | |
tests: rework test parameters
there were 2 variants of calling getTestParameter:
- parameter, description, default value
- parameter, env value, default value, description, scope
While scope was never actually used and having 2 names for the same value led
to having 2 different entries in the cache file for the same configuration.
This commit removes the variants and simplifies tests parameters by only using
the first 3 parameter variant.
Diffstat (limited to 'plugins/t/check_jabber.t')
| -rw-r--r-- | plugins/t/check_jabber.t | 20 |
1 files changed, 3 insertions, 17 deletions
diff --git a/plugins/t/check_jabber.t b/plugins/t/check_jabber.t index 7a708d5b..fcdae179 100644 --- a/plugins/t/check_jabber.t +++ b/plugins/t/check_jabber.t @@ -10,23 +10,9 @@ use NPTest; plan tests => 10; -my $host_tcp_jabber = getTestParameter( - "NP_HOST_TCP_JABBER", - "A host providing the Jabber Service", - "jabber.org" - ); - -my $host_nonresponsive = getTestParameter( - "NP_HOST_NONRESPONSIVE", - "The hostname of system not responsive to network requests", - "10.0.0.1", - ); - -my $hostname_invalid = getTestParameter( - "NP_HOSTNAME_INVALID", - "An invalid (not known to DNS) hostname", - "nosuchhost", - ); +my $host_tcp_jabber = getTestParameter("NP_HOST_TCP_JABBER", "A host providing the Jabber Service", "jabber.de"); +my $host_nonresponsive = getTestParameter("NP_HOST_NONRESPONSIVE", "The hostname of system not responsive to network requests", "10.0.0.1"); +my $hostname_invalid = getTestParameter("NP_HOSTNAME_INVALID", "An invalid (not known to DNS) hostname", "nosuchhost"); my $jabberOK = '/JABBER OK\s-\s\d+\.\d+\ssecond response time on '.$host_tcp_jabber.' port 5222/'; |