Age | Commit message (Collapse) | Author |
|
Read the configuration file with privileges temporarily dropped if the
code is used by a setuid plugin.
|
|
Our die() function doesn't append a newline character to the message.
|
|
Replace an "if" with the ternary operator.
|
|
|
|
Use Perl's FindBin module to locate the path to utils.pm in
check_file_age.pl and check_mssql.pl, just as we do in other Perl
plugins.
|
|
The puts(3) function already appends a newline character to the string.
|
|
Add two path names to the list of default INI file locations, as some
users/distributions prefer to put configuration files into
subdirectories.
|
|
We might want to spit out a warning when NAGIOS_CONFIG_PATH is used.
While at it, move the function that handles this environment variable to
the bottom.
|
|
|
|
|
|
Change the indentation and formatting of the code in lib/parse_ini.c.
This breaks patches against that file and makes it harder to track its
history, but it (hopefully) improves readability a lot.
|
|
There's no need to cast malloc(3)'s return value.
|
|
The lib/parse_ini.c:np_get_defaults() function now dies if no
configuration file is found.
|
|
Read $MP_CONFIG_FILE if that variable is set in the environment.
|
|
Read "monitoring-plugins.ini" if that file exists, but fall back to
reading "plugins.ini" or "nagios-plugins.ini" for backward
compatibility.
|
|
Rewrite the code that looks up the INI configuration file path (used by
the Extra-Opts feature) in order to improve readability. The behaviour
should not have changed.
|
|
when returning syscontact. So make them optional since we want to test
check_snmp and not the snmpd.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
so make sure our tests only run if -2 maps to nobody
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
on the fping binary. Check this before running the test.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
since the test uses send_header from HTTP::Daemon::ClientConn which has been introduced in
HTTP::Daemon 6.01
|
|
so add configurable/optional timeout to testCmd.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
skip those tests if the uid does not exist
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
We no longer set LIBGNUTLS_CONFIG, as GnuTLS no longer ships a
"libgnutls-config" tool.
|
|
GnuTLS doesn't provide a SSL_CTX_check_private_key() function.
Closes #1254.
|
|
|
|
|
|
|
|
|
|
The SNMPv3 noAuthNoPriv security level, somewhat unintuitively, requires
a security name to be passed along together with the request. Check_snmp
previously did not do this, causing snmpget to throw an error:
"External command error: No log handling enabled - turning on stderr
logging
snmpget: No securityName specified"
This patch fixes the issue by always providing the security name when
noAuthNoPriv is specified.
See also:
https:://bugs.op5.com/view.php?id=8385.
Signed-off-by: Anton Lofgren <alofgren@op5.com>
|
|
anything
|
|
|
|
|
|
If you don't specify a group or a file to read data from the plugin tries to read from several files that don't exist and no groups.
|
|
|
|
|
|
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
|
|
Perl's "taint" checks don't like `use lib "$FindBin::Bin"'.
Cf. http://www.perlmonks.org/?node_id=585299
|
|
|
|
|
|
Remove the buggy and complex awk(1) magic in "plugins-scripts/subst.in"
in favor of simple sed(1) substitutions.
The plugins in the "plugins-scripts" directory now always use the PATH
specified via "./configure --trusted-path", or the default PATH
hard-coded in "configure.ac".
Fixes #1242.
|
|
* awiddersheim/fix_trusted_path:
Fix trusted path
Conflicts:
plugins-scripts/check_ntp.pl
plugins-scripts/subst.in
Closes #1212.
|
|
|
|
It was only used to replace the 'use lib utils.pm' with the proper
libexec dir, which is now solved by using Perl's FinBin.
Closes #1241
|
|
'use lib utils.pm' is not valid Perl syntax:
Bareword "utils" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.
Bareword "pm" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.
This makes it impossible to use the plugins directly from the git tree,
e.g. while hacking on them.
Using FindBin::Bin as the library path allows that, while preserving
the original behaviour of adding the libexec path when the plugin is
properly installed.
|
|
|
|
autodetected
Closes: #1242
|
|
|
|
This is done by looking at some common directories and files each
MTA installs on the system. If no known file is found, the old default
sendmail is used. Of course this still can be overridden by -M.
|
|
This
| allows you to choose whether the so called "rebuild rules" should be
| enabled or disabled. With AM_MAINTAINER_MODE([enable]), they are
| enabled by default, otherwise they are disabled by default. In the
| latter case, if you have AM_MAINTAINER_MODE in configure.ac, and run
| `./configure && make', then make will *never* attempt to rebuild
| configure, Makefile.ins, Lex or Yacc outputs, etc. I.e., this
| disables build rules for files that are usually distributed and that
| users should normally not have to update.
|
| The user can override the default setting by passing either
| `--enable-maintainer-mode' or `--disable-maintainer-mode' to
| configure.
|
| People use AM_MAINTAINER_MODE either because they do not want their
| users (or themselves) annoyed by timestamps lossage (see CVS), or
| because they simply can't stand the rebuild rules and prefer running
| maintainer tools explicitly.
[ https://www.gnu.org/software/automake/manual/automake.html ]
|
|
The old name has been deprecated years ago. The Autoconf documentation
says:
| Previous versions of Autoconf promoted the name configure.in, which is
| somewhat ambiguous (the tool needed to process this file is not
| described by its extension), and introduces a slight confusion with
| config.h.in and so on (for which `.in' means "to be processed by
| configure"). Using configure.ac is now preferred.
[ https://www.gnu.org/software/autoconf/manual/autoconf.html ]
|